From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id 8ED063882130 for ; Thu, 13 Jun 2024 14:43:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8ED063882130 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8ED063882130 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718289806; cv=none; b=lcrXk4NtTgHHcZST8Gz83tqH4J1HOJsp+avFGIFcKVYUghjfiVCDlqS3fJC6l2bh75+iJyuiOawl6kBO6TIwPb5DqGpzyMxJPbwTs9eYL1S4plh5viRhZMLFXn9QQdcHcnBryc92g1q9BpZEkLigfP4Q9C0V3fn82/Fq3O71ynI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718289806; c=relaxed/simple; bh=sg+4LMPIHNcDwDZoBkg3BDtz2LFYSfIO6E+5ZrdLmvo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=TrQJrTHqkaLddmXMxZtScXQ1N5XsEQQogWqBDDn03DkNygAGTW1NVouS3HJnrxR7A3YecIt28Kk4LEX0JzByQv4TplHc0YO6PdwS5KOKKnJZdgs3kGnq4sMpo8vf/2eAl4rnlEe0HsERfLvoXDI+KXmYn1lJOwCRsvoEQ6VoW/4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-57c83100cb4so1083748a12.1 for ; Thu, 13 Jun 2024 07:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718289802; x=1718894602; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sg+4LMPIHNcDwDZoBkg3BDtz2LFYSfIO6E+5ZrdLmvo=; b=R82cbVO0mWCXvdtbptvCM0j8L6wYhpfahhZiomeTiZ8YxyB0rbYFLXoCe8+p+IIvQQ Kjw5CXOodTJBeOpBCNe7D+RvFmqd1WlL993Yk2416NTo9tIgOHvjKyNiALsycxEadaZx UIpdnIxFCrYTyJg+TB2FfYI/5ggGD8ShQ8xmselKlxudtwk0EWW9PdDRkFNaw4j/pDt3 vTrm7D8YIDAtZkUlm3YPcDvvYUTUJ2lCuCMUjs8V4FspzKacgsnFCVahwAwwvsIx+lDw FckQ4Gf4f02dl0dQqgmhbJAqb5U6k6SHntqXRRq/RtGp91w4IKmWhEiKpy6raML4g684 qPPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718289802; x=1718894602; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sg+4LMPIHNcDwDZoBkg3BDtz2LFYSfIO6E+5ZrdLmvo=; b=AtbukK1Ie5oyn6RO58dzzZm8BRI19IzBwTbEI9qxXdHYrIgdftkQbCin5rm+FVaHkr F5XEElHFbXsMohbVhke9q2BUTJnLsWib84SXyj5T3Uld/JVFX3LQOClFocuGxm/QFxDe a8ZAXD4pftqjgwP1lYHx7eqgK+rGCSzMwXiBCJ0vPSkUfBZE0IR5i8PR3I+nWrAWc6hH qXemHJEnI7UBW1G0OGNDJSqAHerK3TxlDCoE+xPggoVcg2AO/EeZGaWRQobHd7dQMB6o XkGmisfAYouTUOIO8aF9XZGPsc1QmDz1fv2ILkqN3tQFbgAmE+u81ZCx6XIrp+cKuCbL oAbQ== X-Forwarded-Encrypted: i=1; AJvYcCXDvm2jZGoXR4Tzm3WapwzwADsxYVRPIZXAt77EomOcuAwtPCsA6KjOwj8qv6hjjdo9XH5u4O98ved8GxRTllcFid+XJUolpQ== X-Gm-Message-State: AOJu0Yysriox8tRzzkIRlJO3YWzji/cJsHy/6y7W+XM0K4uCY2FBjMNY joahseh5LHxkVo+LnBk7B8P/r6Z6x3wcMDh1JpBvfWzGgqT9vYGz X-Google-Smtp-Source: AGHT+IGapE+A7qruX7nTDV2LMirf6x/NtxF33BgGrifnqT2NvmQRRUfNsfr82DGfKHzhtRtcpvtcZg== X-Received: by 2002:a50:cd0e:0:b0:57c:6a02:31d with SMTP id 4fb4d7f45d1cf-57cbd8f2993mr4401a12.33.1718289801825; Thu, 13 Jun 2024 07:43:21 -0700 (PDT) Received: from [192.168.1.23] (ip-149-172-150-237.um42.pools.vodafone-ip.de. [149.172.150.237]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57cb741e725sm964187a12.69.2024.06.13.07.43.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jun 2024 07:43:21 -0700 (PDT) Message-ID: Date: Thu, 13 Jun 2024 16:43:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: rdapp.gcc@gmail.com, gnu-toolchain@rivosinc.com Subject: Re: [PATCH 1/2] RISC-V: Fix vwsll combine on rv32 targets To: Edwin Lu , gcc-patches@gcc.gnu.org References: <20240611222532.2986116-1-ewlu@rivosinc.com> <20240611222532.2986116-2-ewlu@rivosinc.com> <63e6639c-4fa6-4cb2-ab8e-ce437aa68d2f@rivosinc.com> Content-Language: en-US From: Robin Dapp In-Reply-To: <63e6639c-4fa6-4cb2-ab8e-ce437aa68d2f@rivosinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > I did a test run without the subreg condition and it also appears to > work when running on rv32gcv and rv64gcv newlib. Would it be better > to remove the subreg? Yep, if it works, i.e. all tests still pass then let's get rid of it. Regards Robin