From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by sourceware.org (Postfix) with ESMTPS id 400073858C2C for ; Mon, 13 Feb 2023 14:42:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 400073858C2C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x102a.google.com with SMTP id z14-20020a17090abd8e00b00233bb9d6bdcso7202969pjr.4 for ; Mon, 13 Feb 2023 06:42:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5adrb/v+tBRQae4u3I3OVakhUF/Yz8HmOu6L6dNOPkg=; b=N1ehPa+wKxNXadOvBgLe/o9N+CJFnQ6m7i9Xu/nG+KrZlPvoXPEaoCOqI5G6yXXmEq 6I3Xlh2CiX7rFFDKH2uvZvD2Acvb6rXjR8ZIGnQup6VD4HCMM6TiWzr3ASObRqyXo771 NCPuo1NijDLtSRtFMXjYvn0d/NkvK5RrqNdHG9UJU0NOhdYFjnmz0uQHrRw6EBo+kHTj l3xgwlcDJbw8h3/fE1B9IaN5rK8H87uXdIIdXOOt0PILI/VsVRhmB+X47h96I7tSu7/x ZJh88s6oDkdBGSpcZlj1p9MgJVk4emc0WhwMVe5byyokHgds1WXCYWW0U3dkw9fpYNQ+ svbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5adrb/v+tBRQae4u3I3OVakhUF/Yz8HmOu6L6dNOPkg=; b=WrAAMFFTgRHuyYdi/6HhAosXSyXaomKhEY+wNY2fF30kDYDXxATA9vfPp0cWw+faz4 vsNpypztIgKj6o/9/CKzXD5JxWmsYLviXYYQS2soKi32KhLf0ICgAF/guw82fZYZS62Q mKSHd4ml307hTnXF7gMcVvHhEC1aKP14MSL9FCy6PsrCl6eU0ZEF4QrLbQFa8B1MWXWm 6SmxT63tR2GJP71auONHV/f5ZizBBtwdits4QyY8K+dYUjK9U6f8hNRE3q4nFMN2G8+y 7C+p+EExyjFmhnhtBZh1D/we9Gg358i+7sJoud3QgnQM3T1PcQ3k4F+2MZbDzu8EuUV5 ToeA== X-Gm-Message-State: AO0yUKXxPdWu5QDtlT21qSlA7ee4NifVvkNMCe8YGDeGXxdqe4HbVB+l MKGjEewD0xnezVc+o9ZTxSQS7b1iKEY= X-Google-Smtp-Source: AK7set/bjksFhXVmUQGDo5eApsvp7uFzZcCI3vTfO+GQK58Q66x31LV0b07MWEHxKNOY/NdzM6PoEA== X-Received: by 2002:a17:90b:1b12:b0:230:a5e6:daa9 with SMTP id nu18-20020a17090b1b1200b00230a5e6daa9mr27107444pjb.36.1676299344121; Mon, 13 Feb 2023 06:42:24 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id l21-20020a17090aec1500b00230a3b016fcsm5101222pjy.10.2023.02.13.06.42.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Feb 2023 06:42:23 -0800 (PST) Message-ID: Date: Mon, 13 Feb 2023 07:42:22 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] tree-optimization/106722 - fix CD-DCE edge marking Content-Language: en-US To: Richard Biener , gcc-patches@gcc.gnu.org Cc: Jan Hubicka References: <20230210101245.1440C385B514@sourceware.org> From: Jeff Law In-Reply-To: <20230210101245.1440C385B514@sourceware.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/10/23 03:12, Richard Biener via Gcc-patches wrote: > The following fixes a latent issue when we mark control edges but > end up with marking a block with no stmts necessary. In this case > we fail to mark dependent control edges of that block. > > Bootstrapped and tested on x86_64-unknown-linux-gnu. > > Does this look OK? > > Thanks, > Richard. > > PR tree-optimization/106722 > * tree-ssa-dce.cc (mark_last_stmt_necessary): Return > whether we marked a stmt. > (mark_control_dependent_edges_necessary): When > mark_last_stmt_necessary didn't mark any stmt make sure > to mark its control dependent edges. > (propagate_necessity): Likewise. > > * gcc.dg/torture/pr108737.c: New testcase. > diff --git a/gcc/tree-ssa-dce.cc b/gcc/tree-ssa-dce.cc > index b2fe9f4f55e..21b3294fc86 100644 > --- a/gcc/tree-ssa-dce.cc > +++ b/gcc/tree-ssa-dce.cc > @@ -327,17 +327,23 @@ mark_stmt_if_obviously_necessary (gimple *stmt, bool aggressive) > > /* Mark the last statement of BB as necessary. */ > > -static void > +static bool Function comment probably needs an update for the new return value. OK with that fix. jeff