* dwarf2out suspicious code
@ 2019-08-22 20:14 Nathan Sidwell
2019-08-23 11:26 ` Richard Biener
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Sidwell @ 2019-08-22 20:14 UTC (permalink / raw)
To: GCC Patches, Jan Hubička, Richard Biener
Honza, Ricard,
I fell over this assert in dwarf2out.c, but the later comment says it
can happen?? does a checking build fail on LTO?
static inline void
add_AT_die_ref (dw_die_ref die, enum dwarf_attribute attr_kind,
dw_die_ref targ_die)
{
dw_attr_node attr;
gcc_checking_assert (targ_die != NULL);
/* With LTO we can end up trying to reference something we didn't create
a DIE for. Avoid crashing later on a NULL referenced DIE. */
if (targ_die == NULL)
return;
nathan
--
Nathan Sidwell
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: dwarf2out suspicious code
2019-08-22 20:14 dwarf2out suspicious code Nathan Sidwell
@ 2019-08-23 11:26 ` Richard Biener
0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2019-08-23 11:26 UTC (permalink / raw)
To: Nathan Sidwell; +Cc: GCC Patches, Jan Hubička
On Thu, Aug 22, 2019 at 8:59 PM Nathan Sidwell <nathan@acm.org> wrote:
>
> Honza, Ricard,
>
> I fell over this assert in dwarf2out.c, but the later comment says it
> can happen?? does a checking build fail on LTO?
Huh, certainly loosks odd. So I suggest you try yourself
(with LTO bootstrap?). It was added as a fix for PR45089
though. But that didn't have early debug...
Richard.
> static inline void
> add_AT_die_ref (dw_die_ref die, enum dwarf_attribute attr_kind,
> dw_die_ref targ_die)
> {
> dw_attr_node attr;
> gcc_checking_assert (targ_die != NULL);
>
> /* With LTO we can end up trying to reference something we didn't create
> a DIE for. Avoid crashing later on a NULL referenced DIE. */
> if (targ_die == NULL)
> return;
>
> nathan
> --
> Nathan Sidwell
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-23 11:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-22 20:14 dwarf2out suspicious code Nathan Sidwell
2019-08-23 11:26 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).