From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 36D9F3858D32 for ; Mon, 19 Jun 2023 08:03:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 36D9F3858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="6.00,254,1681200000"; d="diff'?scan'208";a="10298544" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 19 Jun 2023 00:03:03 -0800 IronPort-SDR: +xdxyJTEV6iOCA6rFbTmKV84L9GYnvrgF+j2/zk5Arh1vQiKBQIsw3+36qDiV4Dfyh0lk3quTV wlqyFJGgjIJ5O7JI2WUJp7ylS2DzgEXWImTM+jhvUXOgrVVIqSOzcNJDVtt0aj2/0+mHOIgV6+ OVFP67mptHOR9N/bfYvYlp9vENPkKOx4e9/LQkl4fZ6HYNoHbBNLQLY+2w0297orlVkAj6QhkL sHf8UKPrDzrGUxZBXidfmpdJnTmN3tYiOq/KSZ2YonT1KFn2I2L62yLzpN1txDtFmRwpy4vZfy suo= Content-Type: multipart/mixed; boundary="------------q0D8IgX9jPNyvKiBEKgYMTIX" Message-ID: Date: Mon, 19 Jun 2023 10:02:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: [committed] libgomp.c/target-51.c: Accept more error-msg variants in dg-output (was: Re: [committed] libgomp: Fix OMP_TARGET_OFFLOAD=mandatory) Content-Language: en-US To: Thomas Schwinge CC: References: <1487d7d4-8611-0d78-6bf2-9bffdd4daa64@codesourcery.com> <91bb9136-f8a4-e516-3f42-ed6d66dc8ce0@codesourcery.com> <87cz1vf8as.fsf@euler.schwinge.homeip.net> From: Tobias Burnus In-Reply-To: <87cz1vf8as.fsf@euler.schwinge.homeip.net> X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --------------q0D8IgX9jPNyvKiBEKgYMTIX Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable On 16.06.23 22:42, Thomas Schwinge wrote: > I see the new tests PASS, but with offloading enabled (nvptx) also see: > > PASS: libgomp.c/target-51.c (test for excess errors) > PASS: libgomp.c/target-51.c execution test > [-PASS:-]{+FAIL:+} libgomp.c/target-51.c output pattern test > > ... due to: > > Output was: > > libgomp: OMP_TARGET_OFFLOAD is set to MANDATORY, but device cannot b= e used for offloading > > Should match: > .*libgomp: OMP_TARGET_OFFLOAD is set to MANDATORY, but device not fo= und.* Thanks for the report. I can offer yet another wording for the same program= =E2=80=93 and also with nvptx enabled: libgomp: OMP_TARGET_OFFLOAD is set to MANDATORY, but device cannot be used = for offloading And I can also offer (which is already in the testcase with "! offload_devi= ce"): libgomp: OMP_TARGET_OFFLOAD is set to MANDATORY, but only the host device i= s available I think I will just match "..., but .*" without distinguishing check_effect= ive_target_* ... ... which I now did in commit r14-1926-g01fe115ba7eafe (see also attached p= atch). * * * With offloading, there are simply too many possibilities: * Not compiled with offloading support - vs. with (ENABLE_OFFLOADING) * Support compiled in but either compiler or library support not installed (requires configuring with --enable-offload-defaulted) * Offloading libgomp plugins there but no CUDA or hsa runtime libraries * The latter being installed but no device available Plus -foffload=3Ddisable or only enabling an (at runtime) unavailable or unsupported device type or other issues like CUDA and device present but an issue with the kernel driver (or similar half-broken states) or ... [And with remote testing issues related to dg-set-target-env-var and only few systems supporting offloading, a full test coverage is even harder.] Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --------------q0D8IgX9jPNyvKiBEKgYMTIX Content-Type: text/x-patch; charset="UTF-8"; name="committed.diff" Content-Disposition: attachment; filename="committed.diff" Content-Transfer-Encoding: base64 Y29tbWl0IDAxZmUxMTViYTdlYWZlYmNmOTdiYmFjOWUxNTcwMzhhMDAzZDBjODUKQXV0aG9y OiBUb2JpYXMgQnVybnVzIDx0b2JpYXNAY29kZXNvdXJjZXJ5LmNvbT4KRGF0ZTogICBNb24g SnVuIDE5IDA5OjUyOjEwIDIwMjMgKzAyMDAKCiAgICBsaWJnb21wLmMvdGFyZ2V0LTUxLmM6 IEFjY2VwdCBtb3JlIGVycm9yLW1zZyB2YXJpYW50cyBpbiBkZy1vdXRwdXQKICAgIAogICAg RGVwZW5kaW5nIG9uIHRoZSBkZXRhaWxzLCB0aGUgdGVzdGNhc2UgY2FuIGZhaWwgd2l0aCBk aWZmZXJlbnQgYnV0CiAgICByZWxhdGVkIG1lc3NhZ2VzOyBhbGwgb2YgdGhlIGZvbGxvd2lu ZyBhbGwgY291bGQgYmUgb2JzZXJ2ZWQgZm9yIHRoaXMKICAgIHRlc3RjYXNlOgogICAgCiAg ICAgIGxpYmdvbXA6IE9NUF9UQVJHRVRfT0ZGTE9BRCBpcyBzZXQgdG8gTUFOREFUT1JZLCBi dXQgZGV2aWNlIGNhbm5vdCBiZSB1c2VkIGZvciBvZmZsb2FkaW5nCiAgICAgIGxpYmdvbXA6 IE9NUF9UQVJHRVRfT0ZGTE9BRCBpcyBzZXQgdG8gTUFOREFUT1JZLCBidXQgZGV2aWNlIG5v dCBmb3VuZAogICAgICBsaWJnb21wOiBPTVBfVEFSR0VUX09GRkxPQUQgaXMgc2V0IHRvIE1B TkRBVE9SWSwgYnV0IG9ubHkgdGhlIGhvc3QgZGV2aWNlIGlzIGF2YWlsYWJsZQogICAgCiAg ICBCZWZvcmUsIHRoZSBsYXN0IHR3byB3ZXJlIHRlc3RlZCBmb3Igd2l0aCAndGFyZ2V0IG9m ZmxvYWRfZGV2aWNlJyBhbmQKICAgICchIG9mZmxvYWRfZGV2aWNlJywgcmVzcGVjdGl2ZWx5 LiBOb3csIGFsbCB0aHJlZSBhcmUgYWNjZXB0ZWQgYnkgbWF0Y2hpbmcKICAgICcuKicgYWxy ZWFkeSBhZnRlciAnYnV0JyBhbmQgd2l0aG91dCBkaXN0aW5ndWlzaGluZyB3aGV0aGVyIHRo ZSBlZmZlY3RpdmUKICAgIHRhcmdldCBpcyBhbiBvZmZsb2FkX2RldmljZSBvciBub3QuCiAg ICAKICAgIChGb3IgY29tcGxldGVuZXNzLCB0aGVyZSBpcyBhIGZvdXJ0aCBlcnJvciB0aGF0 IGZvbGxvd3MgdGhpcyBwYXR0ZXJuOgogICAgJ09NUF9UQVJHRVRfT0ZGTE9BRCBpcyBzZXQg dG8gTUFOREFUT1JZLCBidXQgZGV2aWNlIGlzIGZpbmFsaXplZCcuKQogICAgCiAgICBsaWJn b21wLwogICAgCiAgICAgICAgICAgICogdGVzdHN1aXRlL2xpYmdvbXAuYy90YXJnZXQtNTEu YzogQWNjZXB0IG1vcmUgZXJyb3IgbXNnIHZhcmlhbnRzCiAgICAgICAgICAgIGFzIGV4cGVj dGVkIGRnLW91dHB1dC4KLS0tCiBsaWJnb21wL3Rlc3RzdWl0ZS9saWJnb21wLmMvdGFyZ2V0 LTUxLmMgfCAzICstLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAyIGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpYmdvbXAvdGVzdHN1aXRlL2xpYmdvbXAuYy90YXJn ZXQtNTEuYyBiL2xpYmdvbXAvdGVzdHN1aXRlL2xpYmdvbXAuYy90YXJnZXQtNTEuYwppbmRl eCBiYmU5YWRlNmUyNC4uZGIwMzYzYmZjMTQgMTAwNjQ0Ci0tLSBhL2xpYmdvbXAvdGVzdHN1 aXRlL2xpYmdvbXAuYy90YXJnZXQtNTEuYworKysgYi9saWJnb21wL3Rlc3RzdWl0ZS9saWJn b21wLmMvdGFyZ2V0LTUxLmMKQEAgLTksOCArOSw3IEBACiAKIC8qIFNlZSBjb21tZW50IGlu IHRhcmdldC01MC5jL3RhcmdldC01MC5jIGZvciB3aHkgdGhlIG91dHB1dCBkaWZmZXJzLiAg Ki8KIAotLyogeyBkZy1vdXRwdXQgIi4qbGliZ29tcDogT01QX1RBUkdFVF9PRkZMT0FEIGlz IHNldCB0byBNQU5EQVRPUlksIGJ1dCBvbmx5IHRoZSBob3N0IGRldmljZSBpcyBhdmFpbGFi bGUuKiIgeyB0YXJnZXQgeyAhIG9mZmxvYWRfZGV2aWNlIH0gfSB9ICovCi0vKiB7IGRnLW91 dHB1dCAiLipsaWJnb21wOiBPTVBfVEFSR0VUX09GRkxPQUQgaXMgc2V0IHRvIE1BTkRBVE9S WSwgYnV0IGRldmljZSBub3QgZm91bmQuKiIgeyB0YXJnZXQgb2ZmbG9hZF9kZXZpY2UgfSB9 ICovCisvKiB7IGRnLW91dHB1dCAiLipsaWJnb21wOiBPTVBfVEFSR0VUX09GRkxPQUQgaXMg c2V0IHRvIE1BTkRBVE9SWSwgYnV0IC4qIiB9IH0gKi8KIAogaW50CiBtYWluICgpCg== --------------q0D8IgX9jPNyvKiBEKgYMTIX--