From: Jeff Law <jeffreyalaw@gmail.com>
To: Paul Koning <paulkoning@comcast.net>,
Mikael Pettersson <mikpelinux@gmail.com>
Cc: gcc-patches@gcc.gnu.org, Paul Koning <ni1d@arrl.net>
Subject: Re: [PATCH] fix pdp11_expand_epilogue (PR target/107841)
Date: Thu, 13 Jul 2023 12:52:10 -0600 [thread overview]
Message-ID: <f100d384-6fa0-f643-333c-f986e1604d3c@gmail.com> (raw)
In-Reply-To: <04978D0F-FEED-4BB6-9687-D7DB20DD4C29@comcast.net>
On 7/13/23 11:46, Paul Koning via Gcc-patches wrote:
>
>
>> On Jul 13, 2023, at 12:47 PM, Mikael Pettersson <mikpelinux@gmail.com> wrote:
>>
>> If the stack frame only contains an alloca area, then
>> pdp11_expand_epilogue fails to deallocate it, resulting
>> in callee-saved registers and the return address being
>> restored from the wrong stack slots. Fixed by adding
>> || cfun->calls_alloca to the condition for deallocating
>> the frame.
>>
>> Tested with a cross to pdp11-unknown-aout.
>>
>> Ok for master? (Note: I don't have commit rights.)
>
> Yes, thank you!
>
> Question for the experts: how is this handled? Do I need to apply this change to my workspace and commit it, with Mikael as the change author?
That's what I usually do for someone without write access. commit it
locally using the --author flag, then push.
jeff
next prev parent reply other threads:[~2023-07-13 18:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 16:47 Mikael Pettersson
2023-07-13 17:46 ` Paul Koning
2023-07-13 18:52 ` Jeff Law [this message]
2023-07-27 11:51 ` Maciej W. Rozycki
2023-07-13 20:10 ` Paul Koning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f100d384-6fa0-f643-333c-f986e1604d3c@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikpelinux@gmail.com \
--cc=ni1d@arrl.net \
--cc=paulkoning@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).