From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id EC5C63858CDA for ; Mon, 25 Jul 2022 22:37:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EC5C63858CDA Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-43-sfpwF0LKN0urqJgXjfOa2w-1; Mon, 25 Jul 2022 18:37:48 -0400 X-MC-Unique: sfpwF0LKN0urqJgXjfOa2w-1 Received: by mail-qt1-f198.google.com with SMTP id i8-20020ac871c8000000b0031ed35facf3so6364812qtp.0 for ; Mon, 25 Jul 2022 15:37:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=4ywLBpnKDhuQ2+q5fuQUdQiMDPF+8aa3YCgNmMy/fzU=; b=03sXbnKudi7eWFKHBiiVEIEiRLgMNCw4jEbiislmKZ22S/nZkYNd2GBiiLI4sUl9Md W6kUBGidnm6caAlFTLIKvEBGJR/vZxfWRIXuXUXSZFe3VOpBDfb49xI8PUBpU3JScFYE Iuq62siKtOAvsGn+ZYOZsDRuUhi84xzCAIsScdWaIkrPudqfluk/37tKtXe6soluh6dn rQvsUTCc8eUmf23IIpuZRF+SNS2/eU5xs7H6Kx5PVX/SuURrCyJOtQT/41pmk80Gwqnw XR7LRQocgpJHf4NyKs89UgLUqO7x4hd/iW8VkdeLrVjF58uOw6jkpvN7j7Bj90eKPxke lP6g== X-Gm-Message-State: AJIora8gvuV391Rs/PABZq7GFCJJOPe6Sll36iix/Ii8jrUERR0BIGnZ isQT0tI+vcH17DX3/7l/woLZUiqOqXR1y1HbWIYiHHouM6RFOHdiS/0Twy3ZYLQqbNPF7/MACKP glrYuQ+EEh7pY4i57Jw== X-Received: by 2002:a05:622a:1116:b0:31e:d8e4:ac30 with SMTP id e22-20020a05622a111600b0031ed8e4ac30mr12250574qty.660.1658788667610; Mon, 25 Jul 2022 15:37:47 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s//5EHV9o7fgGrMCKAfyjNx9UpFS/VfCnqBLCoEgaD51BDANmLYi8sLnY0Py4GpgjkygK+lg== X-Received: by 2002:a05:622a:1116:b0:31e:d8e4:ac30 with SMTP id e22-20020a05622a111600b0031ed8e4ac30mr12250559qty.660.1658788667262; Mon, 25 Jul 2022 15:37:47 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.nh.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id t1-20020a05620a450100b006b5e296452csm10905160qkp.54.2022.07.25.15.37.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jul 2022 15:37:46 -0700 (PDT) Message-ID: Subject: Re: [PATCH 2/7] jit,docs: replace c:type:`int_type` with :expr:`int_type` From: David Malcolm To: Martin Liska , gcc-patches@gcc.gnu.org Date: Mon, 25 Jul 2022 18:37:45 -0400 In-Reply-To: <2c70aa99533c104dfc14d8ccd8198ed156b1d9a5.1658754788.git.mliska@suse.cz> References: <2c70aa99533c104dfc14d8ccd8198ed156b1d9a5.1658754788.git.mliska@suse.cz> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2022 22:37:53 -0000 On Mon, 2022-07-25 at 11:03 +0200, Martin Liska wrote: > Use expression that work fine for basic type. What's the motivation for this change? Surely the things being marked up are types, rather than expressions? Dave > > gcc/jit/ChangeLog: > >         * docs/cp/topics/expressions.rst: Use :expr: for basic types. >         * docs/topics/compilation.rst: Likewise. >         * docs/topics/expressions.rst: Likewise. >         * docs/topics/function-pointers.rst: Likewise. > --- >  gcc/jit/docs/cp/topics/expressions.rst    | 6 +++--- >  gcc/jit/docs/topics/compilation.rst       | 4 ++-- >  gcc/jit/docs/topics/expressions.rst       | 6 +++--- >  gcc/jit/docs/topics/function-pointers.rst | 2 +- >  4 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/gcc/jit/docs/cp/topics/expressions.rst > b/gcc/jit/docs/cp/topics/expressions.rst > index 239e004371e..003dbce8991 100644 > --- a/gcc/jit/docs/cp/topics/expressions.rst > +++ b/gcc/jit/docs/cp/topics/expressions.rst > @@ -57,14 +57,14 @@ Simple expressions >                                             int value) const >   >     Given a numeric type (integer or floating point), build an rvalue > for > -   the given constant :c:type:`int` value. > +   the given constant :expr:`int` value. >   >  .. function:: gccjit::rvalue \ >                gccjit::context::new_rvalue (gccjit::type > numeric_type, \ >                                             long value) const >   >     Given a numeric type (integer or floating point), build an rvalue > for > -   the given constant :c:type:`long` value. > +   the given constant :expr:`long` value. >   >  .. function::  gccjit::rvalue \ >                 gccjit::context::zero (gccjit::type numeric_type) > const > @@ -91,7 +91,7 @@ Simple expressions >                                              double value) const >   >     Given a numeric type (integer or floating point), build an rvalue > for > -   the given constant :c:type:`double` value. > +   the given constant :expr:`double` value. >   >  .. function:: gccjit::rvalue \ >                gccjit::context::new_rvalue (gccjit::type > pointer_type, \ > diff --git a/gcc/jit/docs/topics/compilation.rst > b/gcc/jit/docs/topics/compilation.rst > index c5fa6eb0faf..91b9c2533cf 100644 > --- a/gcc/jit/docs/topics/compilation.rst > +++ b/gcc/jit/docs/topics/compilation.rst > @@ -98,8 +98,8 @@ In-memory compilation >     If the global is found, the result will need to be cast to a >     pointer of the correct type before it can be called. >   > -   This is a *pointer* to the global, so e.g. for an :c:type:`int` > this is > -   an :c:type:`int *`. > +   This is a *pointer* to the global, so e.g. for an :expr:`int` > this is > +   an :expr:`int *`. >   >     For example, given an ``int foo;`` created this way: >   > diff --git a/gcc/jit/docs/topics/expressions.rst > b/gcc/jit/docs/topics/expressions.rst > index 49b7e14ae2b..00e2ec8cfeb 100644 > --- a/gcc/jit/docs/topics/expressions.rst > +++ b/gcc/jit/docs/topics/expressions.rst > @@ -60,7 +60,7 @@ Simple expressions >                                                     int value) >   >     Given a numeric type (integer or floating point), build an rvalue > for > -   the given constant :c:type:`int` value. > +   the given constant :expr:`int` value. >   >  .. function:: gcc_jit_rvalue *\ >                gcc_jit_context_new_rvalue_from_long (gcc_jit_context > *ctxt, \ > @@ -68,7 +68,7 @@ Simple expressions >                                                      long value) >   >     Given a numeric type (integer or floating point), build an rvalue > for > -   the given constant :c:type:`long` value. > +   the given constant :expr:`long` value. >   >  .. function::  gcc_jit_rvalue *gcc_jit_context_zero (gcc_jit_context > *ctxt, \ >                                                       gcc_jit_type > *numeric_type) > @@ -96,7 +96,7 @@ Simple expressions >                                                         double value) >   >     Given a numeric type (integer or floating point), build an rvalue > for > -   the given constant :c:type:`double` value. > +   the given constant :expr:`double` value. >   >  .. function:: gcc_jit_rvalue *\ >                gcc_jit_context_new_rvalue_from_ptr (gcc_jit_context > *ctxt, \ > diff --git a/gcc/jit/docs/topics/function-pointers.rst > b/gcc/jit/docs/topics/function-pointers.rst > index e6f9970a7a7..dde49215853 100644 > --- a/gcc/jit/docs/topics/function-pointers.rst > +++ b/gcc/jit/docs/topics/function-pointers.rst > @@ -48,7 +48,7 @@ to it in :c:type:`gcc_jit_rvalue` form using >  type obtained using :c:func:`gcc_jit_context_new_function_ptr_type`. >   >  Here's an example of creating a function pointer type corresponding > to C's > -:c:type:`void (*) (int, int, int)`: > +:expr:`void (*) (int, int, int)`: >   >  .. code-block:: c >