public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH, rs6000, committed] Fix AIX bootstrap (don't call asprintf)
@ 2021-08-23 22:36 Bill Schmidt
  0 siblings, 0 replies; only message in thread
From: Bill Schmidt @ 2021-08-23 22:36 UTC (permalink / raw)
  To: GCC Patches; +Cc: Segher Boessenkool, David Edelsohn

Hi,

My recent commit broke bootstrap for AIX because I was calling asprintf 
without pulling it in from libiberty.h.  Unfortunately, there is a name 
collision between libiberty.h and string.h that I don't immediately know 
how to resolve, so rather than fight it I've just reverted to using 
malloc and sprintf.

Bootstrapped on powerpc64le-linux-gnu, committed as obvious. Sorry for 
the trouble!

Bill


2021-08-23  Bill Schmidt  <wschmidt@linux.ibm.com>

gcc/
	* config/rs6000/rs6000-gen-builtins.c (parse_bif_entry): Don't call
	asprintf, which is not available on AIX.
---
  gcc/config/rs6000/rs6000-gen-builtins.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gcc/config/rs6000/rs6000-gen-builtins.c b/gcc/config/rs6000/rs6000-gen-builtins.c
index 503099464d6..08dc3b5b956 100644
--- a/gcc/config/rs6000/rs6000-gen-builtins.c
+++ b/gcc/config/rs6000/rs6000-gen-builtins.c
@@ -1844,8 +1844,9 @@ parse_bif_entry (void)
    /* Append a number representing the order in which this function
       was encountered to its name, and save in another lookup
       structure.  */
-  char *buf;
-  asprintf (&buf, "%s:%05d", bifs[curr_bif].idname, curr_bif);
+  int orig_len = strlen (bifs[curr_bif].idname);
+  char *buf = (char *) malloc (orig_len + 7);
+  sprintf (buf, "%s:%05d", bifs[curr_bif].idname, curr_bif);
  
    if (!rbt_insert (&bifo_rbt, buf))
      {
-- 
2.27.0



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-08-23 22:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-23 22:36 [PATCH, rs6000, committed] Fix AIX bootstrap (don't call asprintf) Bill Schmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).