public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Robin Dapp <rdapp@linux.ibm.com>
To: Richard Biener <richard.guenther@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, jakub@redhat.com
Subject: Re: VN, len_store and endianness
Date: Tue, 27 Sep 2022 15:19:23 +0200	[thread overview]
Message-ID: <f1442473-a249-3890-9ea5-793ad67877dd@linux.ibm.com> (raw)
In-Reply-To: <CAFiYyc0RWQXBcAqoD_znvWLOqZ-FhKzC9=AYKYa-+f6ywFnYDA@mail.gmail.com>

> The error is probably in vn_reference_lookup_3 which assumes that
> 'len' applies to the vector elements in element order.  See the part
> of the code where it checks for internal_store_fn_p.  If 'len' is with
> respect to the memory and thus endianess has to be taken into
> account then for the IFN_LEN_STORE
> 
>               else if (fn == IFN_LEN_STORE)
>                 {
>                   pd.rhs_off = 0;
>                   pd.offset = offset2i;
>                   pd.size = (tree_to_uhwi (len)
>                              + -tree_to_shwi (bias)) * BITS_PER_UNIT;
>                   if (ranges_known_overlap_p (offset, maxsize,
>                                               pd.offset, pd.size))
>                     return data->push_partial_def (pd, set, set,
>                                                    offseti, maxsizei);
> 
> likely needs to adjust rhs_off from zero for big endian?

Not sure I follow entirely.  rhs_off only seems to be used for
native_encode_expr which properly encodes already ({-1, 1, -1, 1} in
that order in memory).  A 'len' of 12 is the first three elements (in
the same order or element order as well).

If the constant were encoded in little endian ({1, -1, 1, -1}) 'q' would
kind of address the right elements (using always the second, or
"reversed third" element while shifting the buffer by 4 bytes each time).

  reply	other threads:[~2022-09-27 13:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-26 14:21 Robin Dapp
2022-09-27  8:39 ` Richard Biener
2022-09-27 13:19   ` Robin Dapp [this message]
2022-09-27 13:49     ` Richard Biener
2022-09-27 13:59       ` Robin Dapp
2022-09-29  7:32         ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1442473-a249-3890-9ea5-793ad67877dd@linux.ibm.com \
    --to=rdapp@linux.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).