From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 7F6C73858D33 for ; Sun, 21 May 2023 01:25:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F6C73858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1ae763f9c0bso21242825ad.2 for ; Sat, 20 May 2023 18:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684632327; x=1687224327; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Jp9ksAvswxnXLla3dvR56YUPmbuC6XJ61yUOowe5A7A=; b=BQ9PXC9W9hbDedUyZ94EWE14xa+pS1pMJJrBFuQMhoKgyWMrRTIimjdCv1tjuRUmDQ lPZL/v28Uln3GluwjquC51xLLx6NVBMfP3nziy5xh8Ospuc/ut1c8qD0PzjH4loqGCSr muKI1oh7DnWHm0fNotCppAsXJz9NZBmpVOjLtZ3fbKxV7udiIsakcmuADVNKo9X+mMgJ KGcGfa8OBNzVD5GzjDZt8URVUtCF0KYOzTbPcXv+9kHIwkXYfEwgzRshAIDI083sXkmr LfGvzdQL63Uc16rJa2h0FyNtI4WJgRhZ+ljx4UrOHinn9wudq2zbV4HI9CusQ3L0R+BN zOsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684632327; x=1687224327; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Jp9ksAvswxnXLla3dvR56YUPmbuC6XJ61yUOowe5A7A=; b=B+5jFgFtaRYtLGnnXFk356zrM942dpXm2mXXtgrNzwpNmQADTrKvSeLso1F7Vgv9x4 vaEM8bi5CndV4QmJ0OsmDrGYWCxeXgyiZLN2fEA6P27G3Zz+gdEJLruKvEGqUSwDBDL0 1gzTtivOGMJwP714099qIARxrzfXmkP3InbxyTvMp60OZ35DxY/u9XmQcA9yuWjcTG+k tFLdYpAaelUNwM1/J4lOVWTq24fKMIWUf1cm8IYz7RAnLfiNt1NY5F02vyIJxuC1lIRj AOgxpF5iT6bFt2yN9atOv7JcSzqa0VyplwIUkK5wWhtXM/Fkkl1J4lo8sFDV/yHZyHOK uGxg== X-Gm-Message-State: AC+VfDykENvPdbjRz+NZV6mNLdLFxZo10n66wqjAOLTgOzcE0VOEfdFZ b/uc+pjT98sNgDuBzur4lBNVh2/7zQo= X-Google-Smtp-Source: ACHHUZ6w0tSHzgRTzSBul1O9cWek+cUMFgC+mBg/jxYNastWbgc/wrUQLQIEor5KkMlP6T+b53XOUg== X-Received: by 2002:a17:902:ee52:b0:1ae:21a9:d081 with SMTP id 18-20020a170902ee5200b001ae21a9d081mr6883163plo.17.1684632326542; Sat, 20 May 2023 18:25:26 -0700 (PDT) Received: from ?IPV6:2607:fb90:469:b40a:c15c:6a92:5516:c5a5? ([2607:fb90:469:b40a:c15c:6a92:5516:c5a5]) by smtp.gmail.com with ESMTPSA id z5-20020a170903018500b001ae5d21f760sm2116968plg.146.2023.05.20.18.25.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 May 2023 18:25:26 -0700 (PDT) Message-ID: Date: Sat, 20 May 2023 19:25:24 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] Fix PR 109919: ICE in emit_move_insn with some bit tests Content-Language: en-US To: gcc-patches@gcc.gnu.org References: <20230521010949.1957550-1-apinski@marvell.com> From: Jeff Law In-Reply-To: <20230521010949.1957550-1-apinski@marvell.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SCC_BODY_URI_ONLY,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/20/23 19:09, Andrew Pinski via Gcc-patches wrote: > The problem is I used expand_expr with the target but > we don't want to use the target here as it is the wrong > mode for the original expression. The testcase would ICE > deap down while trying to do a move to use the target. > Anyways just calling expand_expr with NULL_EXPR fixes > the issue. > > Committed as obvious after a bootstrap/test on x86_64-linux-gnu. > > PR middle-end/109919 > > gcc/ChangeLog: > > * expr.cc (expand_single_bit_test): Don't use the > target for expand_expr. > > gcc/testsuite/ChangeLog: > > * gcc.c-torture/compile/pr109919-1.c: New test. Thanks. I'll respin the targets that failed. If you don't hear from me, assume everything is happy again after this fix. jeff