From: Jeff Law <jeffreyalaw@gmail.com>
To: Palmer Dabbelt <palmer@dabbelt.com>, Jeff Law <jlaw@ventanamicro.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [committed] [RISC-V] Allow uarchs to set TARGET_OVERLAP_OP_BY_PIECES_P
Date: Tue, 7 May 2024 15:30:31 -0600 [thread overview]
Message-ID: <f19a2e99-ceff-4d86-ad35-9dc220536a87@gmail.com> (raw)
In-Reply-To: <mhng-ddd023ba-8fd0-480b-93a0-180f3821a071@palmer-ri-x1c9>
On 5/7/24 3:24 PM, Palmer Dabbelt wrote:
>> @@ -529,6 +536,7 @@ static const struct riscv_tune_param generic_ooo_tune_info = {
>> 4, /* fmv_cost */
>> false, /* slow_unaligned_access */
>> false, /* use_divmod_expansion */
>> + false, /* overlap_op_by_pieces */
>
> IMO we should turn this on for the generic OOO tuning -- the benchmarks
> say it's not faster for the T-Head OOO cores, but we were all so
> surprised to find that I don't think we even fully trust the benchmarks.
> I'd assume OOO cores are faster with the overlapping stores, so we
> should just lean into it and let vendors say something if that's the
> wrong assumption.
Several factors likely come into play (branch prediction, OOO
properties, write combining, etc etc).
But sure, I don't think that'd be terribly controversial. I can go
ahead and make that change now given its triviality.
Jeff
prev parent reply other threads:[~2024-05-07 21:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 21:18 Jeff Law
2024-05-07 21:24 ` Palmer Dabbelt
2024-05-07 21:30 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f19a2e99-ceff-4d86-ad35-9dc220536a87@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jlaw@ventanamicro.com \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).