Ping on target independent stack clash protection patches

Ping on target independent stack clash protection patches

[Jeff Law]

#01 of #08:
https://gcc.gnu.org/ml/gcc-patches/2017-07/msg01971.html

#02 of #08:
https://gcc.gnu.org/ml/gcc-patches/2017-07/msg01972.html

#03 of #08:
https://gcc.gnu.org/ml/gcc-patches/2017-07/msg01974.html

Need to reach some kind of closure on these, then I can start pinging
the target maintainers for the rest of the bits...

Jeff

Re: Ping on target independent stack clash protection patches

[Eric Botcazou]

> #01 of #08:
> https://gcc.gnu.org/ml/gcc-patches/2017-07/msg01971.html
> 
> #02 of #08:
> https://gcc.gnu.org/ml/gcc-patches/2017-07/msg01972.html
> 
> #03 of #08:
> https://gcc.gnu.org/ml/gcc-patches/2017-07/msg01974.html
> 
> Need to reach some kind of closure on these, then I can start pinging
> the target maintainers for the rest of the bits...

All OK with me, thanks for your attention to the interaction with Ada.

Minor nit:

+   Stack checking is designed to detect infinite recursion for Ada
+   programs.  Furthermore stack checking tries to ensure that scenario
+   that enough stack space is left to run a signal handler.

Let's use the same wording as in invoke.texi: "...infinite recursion and stack 
overflows for...".  Missing "in" before "that scenario'.

[Ada folks in the embedded world are mainly scared about the possibility of 
tasks (threads) overwriting each other's stack; in that case, their only 
requirement is to be able to run a last chance handler to terminate the 
task properly.  But the ACATS testsuite contains a handul of tests that 
litteraly play with stack overflows and this complicates the implementation 
for artificial reasons].

-- 
Eric Botcazou

Re: Ping on target independent stack clash protection patches

[Jeff Law]

On 08/18/2017 09:56 AM, Eric Botcazou wrote:
>> #01 of #08:
>> https://gcc.gnu.org/ml/gcc-patches/2017-07/msg01971.html
>>
>> #02 of #08:
>> https://gcc.gnu.org/ml/gcc-patches/2017-07/msg01972.html
>>
>> #03 of #08:
>> https://gcc.gnu.org/ml/gcc-patches/2017-07/msg01974.html
>>
>> Need to reach some kind of closure on these, then I can start pinging
>> the target maintainers for the rest of the bits...
> 
> All OK with me, thanks for your attention to the interaction with Ada.
> 
> Minor nit:
> 
> +   Stack checking is designed to detect infinite recursion for Ada
> +   programs.  Furthermore stack checking tries to ensure that scenario
> +   that enough stack space is left to run a signal handler.
> 
> Let's use the same wording as in invoke.texi: "...infinite recursion and stack 
> overflows for...".  Missing "in" before "that scenario'.
Both nits fixed.


Jeff