From: Edwin Lu <ewlu@rivosinc.com>
To: gcc-patches@gcc.gnu.org
Cc: gnu-toolchain@rivosinc.com
Subject: Re: [Committed] RISC-V: Add check for types without insn reservations
Date: Thu, 2 Nov 2023 16:01:06 -0700 [thread overview]
Message-ID: <f1f08a6e-418e-4fce-8f78-ad352292996f@rivosinc.com> (raw)
In-Reply-To: <a526dbc1-079b-4da5-a469-271f48e78b07@gmail.com>
On 11/1/2023 11:53 AM, Jeff Law wrote:
>
>
> On 11/1/23 12:17, Edwin Lu wrote:
>> Now that all insns are guaranteed to have a type, ensure every insn
>> is associated with a cpu unit/insn reservation.
>>
>> gcc/ChangeLog:
>>
>> * config/riscv/riscv.cc (riscv_sched_variable_issue): add disabled
>> assert
> OK. Really interested to see how often this trips in practice. I
> suspect often right now ;-)
>
Committed! On a local test with just rv64gc, actually not that many
types were tripped. I think there were around 13 that weren't part of
any reservation
Edwin
> jeff
>>
>
WARNING: multiple messages have this Message-ID
From: Edwin Lu <ewlu@rivosinc.com>
To: Jeff Law <jeffreyalaw@gmail.com>, gcc-patches@gcc.gnu.org
Cc: gnu-toolchain@rivosinc.com
Subject: Re: [Committed] RISC-V: Add check for types without insn reservations
Date: Thu, 2 Nov 2023 16:01:06 -0700 [thread overview]
Message-ID: <f1f08a6e-418e-4fce-8f78-ad352292996f@rivosinc.com> (raw)
Message-ID: <20231102230106.goLGYCbc52Vy62gi9uElXVI6vKlKvdh7drbc1AUL-eY@z> (raw)
In-Reply-To: <a526dbc1-079b-4da5-a469-271f48e78b07@gmail.com>
On 11/1/2023 11:53 AM, Jeff Law wrote:
>
>
> On 11/1/23 12:17, Edwin Lu wrote:
>> Now that all insns are guaranteed to have a type, ensure every insn
>> is associated with a cpu unit/insn reservation.
>>
>> gcc/ChangeLog:
>>
>> * config/riscv/riscv.cc (riscv_sched_variable_issue): add disabled
>> assert
> OK. Really interested to see how often this trips in practice. I
> suspect often right now ;-)
>
Committed! On a local test with just rv64gc, actually not that many
types were tripped. I think there were around 13 that weren't part of
any reservation
Edwin
> jeff
>>
>
next prev parent reply other threads:[~2023-11-02 23:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 18:17 [PATCH] " Edwin Lu
2023-11-01 18:53 ` Jeff Law
2023-11-02 23:01 ` Edwin Lu [this message]
2023-11-02 23:01 ` [Committed] " Edwin Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1f08a6e-418e-4fce-8f78-ad352292996f@rivosinc.com \
--to=ewlu@rivosinc.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gnu-toolchain@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).