From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out30-42.freemail.mail.aliyun.com (out30-42.freemail.mail.aliyun.com [115.124.30.42]) by sourceware.org (Postfix) with ESMTPS id 03AEB3858D37; Sat, 12 Feb 2022 08:43:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 03AEB3858D37 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R861e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e04423; MF=ashimida@linux.alibaba.com; NM=1; PH=DS; RN=11; SR=0; TI=SMTPD_---0V4DDubE_1644655399; Received: from 192.168.193.145(mailfrom:ashimida@linux.alibaba.com fp:SMTPD_---0V4DDubE_1644655399) by smtp.aliyun-inc.com(127.0.0.1); Sat, 12 Feb 2022 16:43:20 +0800 Message-ID: Date: Sat, 12 Feb 2022 00:43:18 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH] [PATCH,v4,1/1,AARCH64][PR102768] aarch64: Add compiler support for Shadow Call Stack Content-Language: en-US To: gcc-patches@gcc.gnu.org, richard.earnshaw@arm.com, marcus.shawcroft@arm.com, kyrylo.tkachov@arm.com, hp@gcc.gnu.org, ndesaulniers@google.com, nsz@gcc.gnu.org, pageexec@gmail.com, qinzhao@gcc.gnu.org, linux-hardening@vger.kernel.org, richard.sandiford@arm.com References: <20220205110500.47430-1-ashimida@linux.alibaba.com> <93a72e23-3d67-3c46-308d-f69ec517e793@linux.alibaba.com> <74fb3167-f5d7-84dd-1348-c9ea18665b58@linux.alibaba.com> <81b35033-489e-d0c0-8677-55923f6abbe0@linux.alibaba.com> From: Dan Li In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH, KAM_DMARC_STATUS, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Feb 2022 08:43:26 -0000 On 2/11/22 07:35, Richard Sandiford wrote: > Dan Li writes: >> On 2/11/22 01:53, Richard Sandiford wrote: >>> Dan Li writes: >>>> On 2/10/22 01:55, Richard Sandiford wrote: >>>>>> >> And I think maybe we could handle this through three patches: >> 1.Keep current patch (a V5) unchanged for scs. >> 2.Add shrink-warpping for X30: >> logically this might be a separate topic, and I think more testing >> might be needed here (Well, I'm a little worried about if there might >> be other effects, since I just read this part of the code roughly >> yesterday). >> 3.Add scs push/pop to shrink-wrapping (and maybe we can do the same for >> the PAC code in pro/epilogue, since it's also the operation of the X30). > > Yeah, that's fair. > > (Like I said earlier, I wasn't asking for the shrink-wrapping change. > It was just a note in passing. But as you point out, the individual > shrink-wrapping support would be even more work than I'd imagined.) Hi, Richard, I have sent out the v5[1] and rebased it to mainline at the same time, please let me know if there is anything else I need to do :) [1].https://gcc.gnu.org/pipermail/gcc-patches/2022-February/590311.html Thanks, Dan