From: Jeff Law <jeffreyalaw@gmail.com>
To: Robin Dapp <rdapp@linux.ibm.com>,
gcc-patches@gcc.gnu.org, richard.sandiford@arm.com
Subject: Re: [PATCH v3 7/7] ifcvt: Run second pass if it is possible to omit a temporary.
Date: Wed, 8 Dec 2021 18:24:00 -0700 [thread overview]
Message-ID: <f2279c85-eafd-0c08-0879-d3b0110a7947@gmail.com> (raw)
In-Reply-To: <20211206184352.42264-8-rdapp@linux.ibm.com>
On 12/6/2021 11:43 AM, Robin Dapp via Gcc-patches wrote:
> If one of the to-be-converted SETs requires the original comparison
> (i.e. in order to generate a min/max insn) but no other insn after it
> does, we can omit creating temporaries, thus facilitating costing.
> ---
> gcc/ifcvt.c | 33 +++++++++++++++++++++++++++++++--
> 1 file changed, 31 insertions(+), 2 deletions(-)
I'd generally prefer to refactor the bits between the restart label and
the goto restart into a function and call it twice, passing in the
additional bits to allow for better costing. Can you look into that?
If it's going to be major surgery, then the goto approach will be OK.
Conceptually I don't have any concerns with the patch. It'll obviously
need a ChangeLog entry.
Jeff
next prev parent reply other threads:[~2021-12-09 1:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 18:43 [PATCH v3 0/7] ifcvt: Convert multiple Robin Dapp
2021-12-06 18:43 ` [PATCH v3 1/7] ifcvt: Check if cmovs are needed Robin Dapp
2021-12-09 1:26 ` Jeff Law
2022-01-10 11:17 ` Robin Dapp
2021-12-06 18:43 ` [PATCH v3 2/7] ifcvt: Allow constants for noce_convert_multiple Robin Dapp
2021-12-08 23:51 ` Jeff Law
2022-01-10 11:17 ` Robin Dapp
2021-12-06 18:43 ` [PATCH v3 3/7] ifcvt: Improve costs handling " Robin Dapp
2021-12-08 23:54 ` Jeff Law
2022-01-10 11:17 ` Robin Dapp
2021-12-06 18:43 ` [PATCH v3 4/7] ifcvt/optabs: Allow using a CC comparison for emit_conditional_move Robin Dapp
2021-12-09 0:11 ` Jeff Law
2021-12-09 17:20 ` Robin Dapp
2021-12-09 17:34 ` Jeff Law
2022-01-10 11:18 ` Robin Dapp
2021-12-06 18:43 ` [PATCH v3 5/7] ifcvt: Try re-using CC for conditional moves Robin Dapp
2021-12-09 1:18 ` Jeff Law
2022-01-10 11:18 ` Robin Dapp
2021-12-06 18:43 ` [PATCH v3 6/7] testsuite/s390: Add tests for noce_convert_multiple Robin Dapp
2021-12-08 23:48 ` Jeff Law
2022-01-10 11:18 ` Robin Dapp
2021-12-06 18:43 ` [PATCH v3 7/7] ifcvt: Run second pass if it is possible to omit a temporary Robin Dapp
2021-12-09 1:24 ` Jeff Law [this message]
2021-12-10 15:06 ` Robin Dapp
2021-12-15 20:24 ` Jeff Law
2022-01-10 11:18 ` Robin Dapp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2279c85-eafd-0c08-0879-d3b0110a7947@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rdapp@linux.ibm.com \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).