From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38175 invoked by alias); 3 Sep 2019 19:38:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 38042 invoked by uid 89); 3 Sep 2019 19:38:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1708 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Sep 2019 19:38:00 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 825243680A; Tue, 3 Sep 2019 19:37:59 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-3.rdu2.redhat.com [10.10.112.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id AC2BD5DC1B; Tue, 3 Sep 2019 19:37:58 +0000 (UTC) Subject: Re: [PATCH 1/3] Implement TARGET_HANDLE_GENERIC_ATTRIBUTE To: Jozef Lawrynowicz , "gcc-patches@gcc.gnu.org" References: <20190830110740.731a0ae0@jozef-kubuntu> <20190830110943.685c4c9e@jozef-kubuntu> From: Jeff Law Openpgp: preference=signencrypt Message-ID: Date: Tue, 03 Sep 2019 19:38:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190830110943.685c4c9e@jozef-kubuntu> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00145.txt.bz2 On 8/30/19 4:09 AM, Jozef Lawrynowicz wrote: > The attached patch adds a new target hook "TARGET_HANDLE_GENERIC_ATTRIBUTE" > which enables a back end to perform additional processing of an attribute that > is normally handled by a front end. > > So far only the "section" and "noinit" attribute make use of this hook, as the > msp430 back end requires additional attribute conflict checking to be performed > on these generic attributes. > > > 0001-Implement-TARGET_HANDLE_GENERIC_ATTRIBUTE.patch > > From e693da709114df378e2ea8b1d3729b105c99a495 Mon Sep 17 00:00:00 2001 > From: Jozef Lawrynowicz > Date: Wed, 28 Aug 2019 14:09:20 +0100 > Subject: [PATCH 1/3] Implement TARGET_HANDLE_GENERIC_ATTRIBUTE > > gcc/ChangeLog: > > 2019-08-29 Jozef Lawrynowicz > > * config/msp430/msp430.c (TARGET_HANDLE_GENERIC_ATTRIBUTE): Define. > (msp430_handle_generic_attribute): New function. > * doc/tm.texi: Regenerate. > * doc/tm.texi.in: Add TARGET_HANDLE_GENERIC_ATTRIBUTE. > * hooks.c (hook_tree_treeptr_tree_tree_int_boolptr_null): New. > * hooks.h (hook_tree_treeptr_tree_tree_int_boolptr_null): New. > * target.def: Define new hook TARGET_HANDLE_GENERIC_ATTRIBUTE. > > gcc/c-family/ChangeLog: > > 2019-08-29 Jozef Lawrynowicz > > * c-attribs.c (handle_section_attribute): Call the > handle_generic_attribute target hook after performing target > independent processing. > (handle_noinit_attribute): Likewise. Just a nit. In a couple places in c-attribs.c you have: > + if (!(* no_add_attrs)) Drop the whitespace between the * and no_add_attrs. OK with that change. jeff