From: Jeff Law <jeffreyalaw@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Thomas Schwinge <tschwinge@baylibre.com>,
Mike Stump <mikestump@comcast.net>,
gcc-patches@gcc.gnu.org, Richard Biener <rguenther@suse.de>,
Rainer Orth <ro@cebitec.uni-bielefeld.de>
Subject: Re: New effective-target 'asm_goto_with_outputs'
Date: Fri, 22 Mar 2024 12:55:56 -0600 [thread overview]
Message-ID: <f294df56-0706-4bb2-ab36-dac6267a1dd6@gmail.com> (raw)
In-Reply-To: <Zf3M50CsSxxsvMg7@tucnak>
On 3/22/24 12:24 PM, Jakub Jelinek wrote:
> On Fri, Mar 22, 2024 at 12:17:03PM -0600, Jeff Law wrote:
>> I'd just make target_lra return false for nvptx rather than creating a new
>
> The lra effective target currently though doesn't check if asm goto can have
> outputs, but rather if the target is using lra.
Right. It's not 100% precise as we lose one testcase for nvptx. THat's
a tradeoff I'd be willing to make.
>
>> selector -- I'm not aware of any features other than asm goto that LRA
>> provides that aren't supported reload.
>>
>> Or perhaps rename the selector entirely to target_asm_goto?
>
> In that case we should just test if asm goto with outputs is allowed
> in a cached snippet, rather than testing if there is LRA in the ra dumps.
I won't lose any sleep with that approach, I just don't see that it adds
a lot of value.
jeff
next prev parent reply other threads:[~2024-03-22 18:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 10:16 [PATCH] testsuite: Fix up lra effective target Jakub Jelinek
2024-02-16 18:43 ` Mike Stump
2024-02-16 18:48 ` Mike Stump
2024-03-21 11:20 ` New effective-target 'asm_goto_with_outputs' (was: [PATCH] testsuite: Fix up lra effective target) Thomas Schwinge
2024-03-22 18:17 ` New effective-target 'asm_goto_with_outputs' Jeff Law
2024-03-22 18:24 ` Jakub Jelinek
2024-03-22 18:55 ` Jeff Law [this message]
2024-04-08 20:13 ` New effective-target 'asm_goto_with_outputs' (was: [PATCH] testsuite: Fix up lra effective target) Thomas Schwinge
2024-02-26 2:10 ` [PATCH] testsuite: Fix up lra effective target Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f294df56-0706-4bb2-ab36-dac6267a1dd6@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=mikestump@comcast.net \
--cc=rguenther@suse.de \
--cc=ro@cebitec.uni-bielefeld.de \
--cc=tschwinge@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).