From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc31.google.com (mail-oo1-xc31.google.com [IPv6:2607:f8b0:4864:20::c31]) by sourceware.org (Postfix) with ESMTPS id 1BDCB3858D1E for ; Fri, 22 Mar 2024 18:55:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1BDCB3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1BDCB3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::c31 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711133769; cv=none; b=m1tXL7ROAVjCX43XauXLMFtp3elXPKPIesdhqbtSRefWCueNxsTk9DqgRp5rK+KJmWxlTUYs8TTCREc8G+ygs/S3wpihrVwuuG8J+eyj9smf7yOb535dm4gjv8ZmdYoBjxiWv/7vMtJtsyMbPuIxaLGCN2J2s8LDuxqMCza5j28= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711133769; c=relaxed/simple; bh=KEIR5jyPx8CwHdjItPTd1y2Z7+ibyIS1ragl6Qlhq+w=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=t+n48txZZ09CLhqXGO1L835apC0wkZvR/7yGDxMLIZ/WqAbEYpeox1MOVeJ+BRXQIwmomswb4hvUUgKyAGTGMqYtZWqNaNeSAhzWO3M9FPZ+gWLnEwS5t5Zhh52Z+FowSpsbvlvDf9enrthrs2WiQZ3+0zGNa+s0aJLz7LosVPw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oo1-xc31.google.com with SMTP id 006d021491bc7-5a4f9f94e77so1333695eaf.3 for ; Fri, 22 Mar 2024 11:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711133758; x=1711738558; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UoMZARxe0RLHLk/zP3goHUAAOKP5X8y0h+Ir9MbXdbQ=; b=a08p3UtNWA7Ehs+XfdCSYWllQeD59fizslAn7IhqAAzjKMNnA5QiM8Iyr6HKDLQot7 yhKbLDkvVF6hd1771/Pce0CPB5nuljnYHuMj3G3pJV5gfeqQodip5PJCv7jQd0DBb9VW vP5SmxJMdjHv38QhK2Co22+MzyDgbQrYUb7I2NbBulMd5Pmy/aZMg2wBkrBlJzUQMV9d b+3hYYbitTasszGAixl1kIvFYQqwFCkzh6RY7NRSbdHXAli/nTuePE0ksgBdLJhNF70l zyD7AbOoS1jVmnN4LGmzbG6PSIWj2CdCmT27+Fb0E6AvCMV2u98S/z1w2NZYBYpe9Dnq usHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711133758; x=1711738558; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UoMZARxe0RLHLk/zP3goHUAAOKP5X8y0h+Ir9MbXdbQ=; b=YIRSXuBIf3wZsTtIiN1xr6qGu2WYGto0bdD3Ho5BKEKzTqeVrSPtrtjbz6mFWm7R2S nxDo3/3huZGLAzfzMzboZCVwsdHRj/T43OcoAOY3u7y5a0V1Eo3gHaWCMcz04pPqTZOy /BiMZMvDuL1BpSTNGkXnn35VmgPdaYTSy5wShWuQy4LT/SNwzH81N0Zgtqhwy4kjamzw f+LKUsTWOV+kugJQbU2voIQQhBLjCnhGwIuSvHrp4rUY4AhN3OPsCOX3771KuSE5boov A3vn5r6vWpZU5WN/HcLsnHrHouYWsutgAQartplMYAc4+RANssiuFzWMZNK9Jh0daGv8 AGbw== X-Forwarded-Encrypted: i=1; AJvYcCUv1n+ETWlnytpzUWnmjQV5sxxfW6Wq9qlmSR0Paqf2E2drhmJl5ZXG9hlIFniXL3autkTux4tHWd56P4UDD0rDUbvb1Iwe0w== X-Gm-Message-State: AOJu0YwXSyRFk9xeSWK4jlP3UHqkme0KgOfz7qwwZF850uJyxxAyBeXh vN10yhIJpc8OtFelkeptjw8vah1w+99NUqiXyJx7ma+6zYMxO/77 X-Google-Smtp-Source: AGHT+IFvN69fJv8Cweq9DFQ4Q6WkC24cP6Alnym1a+CbYEj4igD3f7MP7Cpmb3U55H+Bdx8hZzEtkA== X-Received: by 2002:a05:6870:2009:b0:229:f445:d6b3 with SMTP id o9-20020a056870200900b00229f445d6b3mr660225oab.5.1711133758306; Fri, 22 Mar 2024 11:55:58 -0700 (PDT) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id nd25-20020a056871441900b0022236ebe036sm59292oab.50.2024.03.22.11.55.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Mar 2024 11:55:57 -0700 (PDT) Message-ID: Date: Fri, 22 Mar 2024 12:55:56 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: New effective-target 'asm_goto_with_outputs' Content-Language: en-US To: Jakub Jelinek Cc: Thomas Schwinge , Mike Stump , gcc-patches@gcc.gnu.org, Richard Biener , Rainer Orth References: <2357E81F-095F-4D98-8FE9-767107359BF8@comcast.net> <87ttkzompl.fsf@euler.schwinge.ddns.net> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/22/24 12:24 PM, Jakub Jelinek wrote: > On Fri, Mar 22, 2024 at 12:17:03PM -0600, Jeff Law wrote: >> I'd just make target_lra return false for nvptx rather than creating a new > > The lra effective target currently though doesn't check if asm goto can have > outputs, but rather if the target is using lra. Right. It's not 100% precise as we lose one testcase for nvptx. THat's a tradeoff I'd be willing to make. > >> selector -- I'm not aware of any features other than asm goto that LRA >> provides that aren't supported reload. >> >> Or perhaps rename the selector entirely to target_asm_goto? > > In that case we should just test if asm goto with outputs is allowed > in a cached snippet, rather than testing if there is LRA in the ra dumps. I won't lose any sleep with that approach, I just don't see that it adds a lot of value. jeff