public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Martin Liška" <mliska@suse.cz>
To: gcc-patches@gcc.gnu.org
Cc: gnu@amylaar.uk
Subject: [PATCH] epiphany: fir -Wformat-diag.
Date: Wed, 12 Jan 2022 10:57:30 +0100	[thread overview]
Message-ID: <f2b686ad-3de8-ce0f-6fbc-7cf8225ee1a5@suse.cz> (raw)

This fixes -Wformat-diag warnings.

Ready to be installed?
Thanks,
Martin

gcc/ChangeLog:

	* config/epiphany/epiphany.c (epiphany_handle_interrupt_attribute):
	Use %qs format specifier.
	(epiphany_override_options): Wrap keyword in %<, %>.
---
  gcc/config/epiphany/epiphany.c | 10 ++++++----
  1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/gcc/config/epiphany/epiphany.c b/gcc/config/epiphany/epiphany.c
index 88283419dc1..c9c321560de 100644
--- a/gcc/config/epiphany/epiphany.c
+++ b/gcc/config/epiphany/epiphany.c
@@ -520,8 +520,10 @@ epiphany_handle_interrupt_attribute (tree *node, tree name, tree args,
  	   && strcmp (TREE_STRING_POINTER (value), "swi"))
      {
        warning (OPT_Wattributes,
-	       "argument of %qE attribute is not \"reset\", \"software_exception\", \"page_miss\", \"timer0\", \"timer1\", \"message\", \"dma0\", \"dma1\", \"wand\" or \"swi\"",
-	       name);
+	       "argument of %qE attribute is not %qs, %qs %qs, %qs, %qs, "
+	       "%qs, %qs, %qs, %qs or %qs", name,
+	       "reset", "software_exception", "page_miss", "timer0", "timer1",
+	       "message", "dma0", "dma1", "wand", "swi");
        *no_add_attrs = true;
        return NULL_TREE;
      }
@@ -1538,9 +1540,9 @@ static void
  epiphany_override_options (void)
  {
    if (epiphany_stack_offset < 4)
-    error ("stack_offset must be at least 4");
+    error ("%<stack_offset%> must be at least 4");
    if (epiphany_stack_offset & 3)
-    error ("stack_offset must be a multiple of 4");
+    error ("%<stack_offset%> must be a multiple of 4");
    epiphany_stack_offset = (epiphany_stack_offset + 3) & -4;
   if (!TARGET_SOFT_CMPSF)
     flag_finite_math_only = 1;
-- 
2.34.1


             reply	other threads:[~2022-01-12  9:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-12  9:57 Martin Liška [this message]
2022-01-12 16:21 ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2b686ad-3de8-ce0f-6fbc-7cf8225ee1a5@suse.cz \
    --to=mliska@suse.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gnu@amylaar.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).