From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id 58E303858D39 for ; Fri, 12 May 2023 06:12:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 58E303858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-50bc456cc39so14138282a12.1 for ; Thu, 11 May 2023 23:12:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683871955; x=1686463955; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HH+U6/mZLZFwh/F63kwOgUW000vUqnS8lOwsIdjNAMo=; b=Ne+UxF8EICJlP8OBue9fCoapq1CJZm6m1Yq2NSOb+961DKLk7WPgO06bbMZL4WHLDD QmXPnLQ/0vjDX76mT1z+uVJbvSFt0Hmazwqz9a+FVP0WYsFiXf03gDt+HES9JzOynS7I dX0eXoM3i6oyaneJU1bsZDT8eiAfiNSkhWFVT5Ym6JETW1PgplbVTnCXDVDmCgKO2J+b AOmK4XREAhQiWrqcX+gD4r6vf1dG7k1nEXqAz5gvlR1PFtbsQ8nq8EzZIwT/X4/ADm4L j25hpavy1JHfBpCatVKv2CJI7K8pf1h8BeNA27eWipBp9MJHYylj8Etz53U4LlOSX/Hx fDcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683871955; x=1686463955; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HH+U6/mZLZFwh/F63kwOgUW000vUqnS8lOwsIdjNAMo=; b=kprxWbxEwXfvMAHfMm2kLVLD03dvrknzoZfGSMbbqCtcT2/eAtx/7jRSE+NwCWr55h SY2CzplcGIlAx7z1bqwDjpQ9M0HFsZ4VGCG3d5rTGLCsufDX9jXFTykctbh+Da4M1h7I 2STzmx7ECjx9Eis3SKApIOYpB+bvwI8rje5n0J448p1eIqIxEsjjBvaoE2g08UjSQVC9 JzJXuYGTWl3F3wDQBnSWD4b5A7iSaM+3DlGnLR7nZXKC1jkHRUsLISyv/ALZBqTLif6x v5GFfGH/D7uhvVFd4F86YXKKtxXGRjZf0UzHaUidzlWUV6gvWoKN2L79Wo3Gnl4PDnv5 7mQA== X-Gm-Message-State: AC+VfDwo9/QgppMVI1QNwpZEREbpftbj9HCp0Xl13yk7G1IpnZyzxbHA I/rk39Cd2lNM7QRlW2wHWZjS+CUzf6I= X-Google-Smtp-Source: ACHHUZ5VibySiF0qy1jwH2xUm640XS4biDVoNjFqzAPNEGzjcCx6XLKBX/MV1cWdl3EWj3LTS2kxXA== X-Received: by 2002:a17:906:7943:b0:93f:9b4a:12f3 with SMTP id l3-20020a170906794300b0093f9b4a12f3mr21377366ejo.10.1683871954925; Thu, 11 May 2023 23:12:34 -0700 (PDT) Received: from [192.168.1.23] (ip-046-005-130-086.um12.pools.vodafone-ip.de. [46.5.130.86]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm5024004ejb.18.2023.05.11.23.12.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 May 2023 23:12:34 -0700 (PDT) Message-ID: Date: Fri, 12 May 2023 08:12:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2] RISC-V: Add vector_scalar_shift_operand Content-Language: en-US To: Palmer Dabbelt , gcc-patches@gcc.gnu.org, juzhe.zhong@rivai.ai References: <20230511222848.15044-1-palmer@rivosinc.com> From: Robin Dapp In-Reply-To: <20230511222848.15044-1-palmer@rivosinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > The vector shift immediates happen to have the same constraints as some > of the CSR-related operands, but it's a different usage. This adds a > name for them, so I don't get confused again next time. > > gcc/ChangeLog: > > * config/riscv/autovec.md (shifts): Use > vector_scalar_shift_operand. > * config/riscv/predicates.md (vector_scalar_shift_operand): New > predicate. Hehe, I had something similarly named in the first patch iteration but removed it later. Helps clarity though so fair enough.