From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by sourceware.org (Postfix) with ESMTPS id F12543858D37 for ; Thu, 26 Oct 2023 07:50:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F12543858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F12543858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698306635; cv=none; b=DqSLFoBvQXzm00IvzdTBt7R3oEwRRN0qm38TokCuUZS5UJFKj575fVa2qzzmvHZ6LH3Ia5XxOnh11rVBX4RRLzcy4sLCCrXDoWoe+K2uSdescrnYh3ze1PeClQVq9opOKan3yx9c5pxqEe1LKfRosSbDq1tf04UbyUEsaOc4ADo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698306635; c=relaxed/simple; bh=0CmXfYTzn8WU8adbDv6AjXGLGMPGK40/d+k2krEMp/I=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=p/HTxhhtrzWoA+x4iVwfRTnDzfXD+dy/sO0cAHKqhZIBz3VEDZK9iNlfEiNCS59d7uXN0+qaz7o4Zbzd4dCxVlMAk/OuAevpcHJ9zVOBjmjR8IZurJfwEYA8Mp94abkGUeGI0e7jH774xiy/oEy8C5nxVM/106xhmqW7Jb+0L+k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-40839807e82so3064745e9.0 for ; Thu, 26 Oct 2023 00:50:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698306632; x=1698911432; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=W9aCD9PrqshrDjnxDYFVuwaYz9vEmryPuJi0CBf4bBk=; b=hF7akTUUxFtHKRYUIzQgLdKkWk6/owp3QyqCKO2/He7qsE1oADIS3IdBz251Fo2zNk 34dk98BWHN70z7UCPAyM9J/HDGKl1YDgqPavkvQEZsUgivR6/aDAAYH+vSBzfQBOvpEX J2rgllCQwLJz2RPnmwEG9foNSFVU3wnxbH1aFIJlhV7g3fI2IlU0q9GWHmele+V0DGR5 6W9VhHvJBzEio4xJdRzKfFLfvg8oDWPpkvs539O8Mfw67sXm6SftFv3Cfc/33n6N6hzt VSp/C20+/d+COYP5WIy/UEMMzG5MBugdJhv32Qk5wJaHp4bHt3BKUqqAvjTQ62spauo+ NeUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698306632; x=1698911432; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W9aCD9PrqshrDjnxDYFVuwaYz9vEmryPuJi0CBf4bBk=; b=QhEaqG2u+3iys5QAUdTmstf9tOEAVTVtGB09EHdZINcliKObEtlGmK/mvDzpN2lUaR cPfqHSxhFpcL4MumK2RMtzVxLa/ZB7bSifySKw95fP8IGDXbDH3rjV8b/dJoa/R5zZhF hMpzCce34Fu7KLBReJDCmz8rZISd1oYgBvaVycYHJSbeqUAwH5tMeU1NyiQWpvm/Sxed jbHAf8pNvE4SnseM/knU67DAqtf9ASgr/rRnz1ukhx5t35CftE15f88i8yuolKHJflr5 mTIw2igU/Dbv5G4Kf/v3EJVmJli0WpLxw2y1M4RjflEjCs7h+aWLbCGo9LYGcCb8yQrf 51yg== X-Gm-Message-State: AOJu0YwdQVlvglZEGtTNbXR7102WIny99nps9nsNFT4Bgtv8/hePCWCh BTWZ0G4Zw7NAutdLmEQYgH8= X-Google-Smtp-Source: AGHT+IH0K3SnfJF50X+HeQDLZS21r/wfGZZXynIj3kdufTQ7T/DDSEypbIRgx7fN+zpKTFy5czc6Wg== X-Received: by 2002:a05:600c:15d3:b0:407:5de2:ea4d with SMTP id v19-20020a05600c15d300b004075de2ea4dmr1839826wmf.13.1698306632119; Thu, 26 Oct 2023 00:50:32 -0700 (PDT) Received: from [192.168.1.23] (ip-046-223-203-173.um13.pools.vodafone-ip.de. [46.223.203.173]) by smtp.gmail.com with ESMTPSA id c9-20020a7bc849000000b00405d9a950a2sm1766618wml.28.2023.10.26.00.50.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Oct 2023 00:50:31 -0700 (PDT) Message-ID: Date: Thu, 26 Oct 2023 09:50:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: rdapp.gcc@gmail.com, "kito.cheng" , "Kito.cheng" , jeffreyalaw Subject: Re: [PATCH] RISC-V: Add AVL propagation PASS for RVV auto-vectorization Content-Language: en-US To: "juzhe.zhong@rivai.ai" , "pan2.li" , Patrick O'Neill , gcc-patches References: <20231024033200.224558-1-juzhe.zhong@rivai.ai> <4A9A3B661519DAC3+202310241144138297945@rivai.ai> <6e22f033-887a-3bf1-316a-5e5ec69a3434@rivosinc.com> <0f93e039-9bd3-07f1-2d48-9b4a13efe99b@rivosinc.com> <1635D8934895E936+202310252020243457391@rivai.ai> <07CC46FFE60FF2A1+202310260849149380983@rivai.ai> <2958b17e-bd91-b2fd-fc5c-0a5d4080720e@rivosinc.com> From: Robin Dapp In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Increased FAILS are LMUL = M4. I have analyzed the codegen. Looks > reasonable. > > Moreover, When I removed 'popcount_64' and test, all passed no matter > apply this patch or not. > > I think it is because popcount64 is buggy in RV32, this patch trigger > LMUL = 4 bug already existed that we were lucky. > > So I suggest this patch should go ahead and ignore popcount issue for > now. (I will send V3 with fixing dump FAILs). > > I am not familiar with popcount, Robin. Any suggestions? Yeah, agree. popcount_64 might be wrong and it's unlikely that your patch causes it. Will have a look. Regards Robin