public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Thomas Koenig <tkoenig@netcologne.de>
To: Paul Richard Thomas <paul.richard.thomas@gmail.com>
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>,
	Damian Rouson <damian@sourceryinstitute.org>,
	"Bader, Reinhold" <Reinhold.Bader@lrz.de>
Subject: Re: [Patch, fortran] PR34640 - ICE when assigning item of a derived-component to a pointer
Date: Sun, 09 Jul 2017 21:28:00 -0000	[thread overview]
Message-ID: <f2e82fb4-4806-84ca-4457-a828042dd293@netcologne.de> (raw)
In-Reply-To: <CAGkQGiJpa5aCo6RJDF2G3RiX-iYmOq9gB4i-BPSbJU8x4Tn1hg@mail.gmail.com>

Hi Paul,

> Please find attached what I believe is the final version of the patch.

This is looking very good, this does work as advertised and has
all the corner cases coverd.

I also regtested this on powerpc64-unknown-linux-gnu.

> I took the opportunity of the delay, while the bounds issue was being
> discussed on clf, to fix class pointer arrays. They now function
> correctly, as evidenced by pointer_array_8.f90.

Excellent!

> A possible final tweak - as asked before, should I bump up the module
> version number? My inclination is to say that we should.

Because we are changing the array descriptor (and thus binary
compatibility), we have to change the library version in
libtool-version. Bumping the module version should be done,
too.

> Bootstrapped and regtested on FC23/x86_64 - OK for trunk?

So, OK from my side, with a bump in library and module version.

Maybe you could wait a couple of days before committing to give
others a chance to also test the patch.

Thanks a lot for finally making gfortran F95-compliant!

Regards

	Thomas

  reply	other threads:[~2017-07-09 21:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-24 10:48 Paul Richard Thomas
2017-06-25 10:59 ` Thomas Koenig
2017-06-25 11:43 ` Paul Richard Thomas
2017-07-01 18:17 ` Paul Richard Thomas
2017-07-04 21:04   ` Thomas Koenig
2017-07-09 18:43     ` Paul Richard Thomas
2017-07-09 21:28       ` Thomas Koenig [this message]
2017-07-11  6:16         ` Paul Richard Thomas
2017-07-11 14:24           ` Paul Richard Thomas
2017-07-11 14:48             ` Jerry DeLisle
2017-07-11 18:13               ` Thomas Koenig
2017-07-11 20:23                 ` Paul Richard Thomas
2017-09-11 19:47       ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2e82fb4-4806-84ca-4457-a828042dd293@netcologne.de \
    --to=tkoenig@netcologne.de \
    --cc=Reinhold.Bader@lrz.de \
    --cc=damian@sourceryinstitute.org \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=paul.richard.thomas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).