From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by sourceware.org (Postfix) with ESMTPS id C01CC3858D35 for ; Tue, 27 Dec 2022 15:19:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C01CC3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-io1-xd2d.google.com with SMTP id r72so7027159iod.5 for ; Tue, 27 Dec 2022 07:19:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TvV/6lNEvVWo9DmaUAV1yp9C6Mcg51vWOEwV7fB5iQM=; b=atjbPIn8gXsBfjGzryG+PP8FDWjvz1a3uvZvMCi17skrjG9Dk/WeJoiYKJh+yqHzZy v/EofeB9E1zWchHWeSKR+cxMXvv5XkhknYOU0dFQKmsdT85tq36wqe3kk/I27b7zewV6 rWV9HUWZcJSiQkuo/HjIdsczSrJPwS7bZz/SO+1qApW8hyvHx63t4MzyXlCJAAONC6DH nN98eYHjWeh9Uu7E8r+NJ+iXCCDX94OR64nny7qYL8gNXEA8FLxiPU7NTuGq6hu5hw/O dr8NHJPzT3FehpFo9hCp1zFu/bOhEIo2DUigJS0yV40XBbjjY81S2k1Yixk42VfKsjj9 O7Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TvV/6lNEvVWo9DmaUAV1yp9C6Mcg51vWOEwV7fB5iQM=; b=sFUrEnf94YdNU15NqrfIADtVEuLdrWiSvpnV1Qej9lc8HnZaR/4roWOFEsY/zXHzNu wmvlaFXOwrLYCGZQyZTOToOXCgTFSLQFeGo1INI/K991KKmF4cMXI0I96bfbHA04kifT kY69/Gu71iPc7cozvab3hP3NADeUw8dkl4+vbs0X1sVMlNK1K+B8YEzGtFUiBXOJoLPM 8ejYmtqltwO1vuOB+JtGRIOJhZP+kYumkPdbvqAwatdNQkOmbPmetr3w8/8ZNdrn4EHD pSVgl/xbegJHAKt0HYZkE5gGDdcUfhVk88jfFRJK1JjYNubvKJybFLWeWFZRP1YhJGze 6d6w== X-Gm-Message-State: AFqh2kpwf2HEaXL7JzQ9I4eT1vLwr5gJLFx+ug2W8UTe9/CF5BUdMF5l /OIjf/Mp8YGfOitNlBoud+I= X-Google-Smtp-Source: AMrXdXvVRNTp0ewVvJQcBX1g/TB+K8Yk2H6A/zrd25uLrGqwh/aBKSLL+17AYFLnTJDFalAykGGgiQ== X-Received: by 2002:a5d:9801:0:b0:6e4:eab7:8c67 with SMTP id a1-20020a5d9801000000b006e4eab78c67mr13585665iol.14.1672154348842; Tue, 27 Dec 2022 07:19:08 -0800 (PST) Received: from [172.31.1.18] (65-130-81-249.slkc.qwest.net. [65.130.81.249]) by smtp.gmail.com with ESMTPSA id h4-20020a056602154400b006e302b99d00sm5133970iow.20.2022.12.27.07.19.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Dec 2022 07:19:08 -0800 (PST) Message-ID: Date: Tue, 27 Dec 2022 08:19:06 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [05/13] ssa-loop-niter: skip caching of null operands Content-Language: en-US To: Alexandre Oliva , gcc-patches@gcc.gnu.org References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/26/22 21:22, Alexandre Oliva via Gcc-patches wrote: > > When a TREE_OPERAND is NULL, do not cache it. > > Regstrapped on x86_64-linux-gnu. Ok to install? > > > for gcc/ChangeLog > > * tree-ssa-loop-niter.cc (expand_simple_operands): Refrain > from caching NULL TREE_OPERANDs. I must admit some curiosity about the NULL operand though. Do you recall what kind of node had a NULL operand and whether or not that was a valid state or not? I just want to make sure this isn't just papering over a deeper issue. jeff