From: "Martin Liška" <mliska@suse.cz>
To: Nathan Sidwell <nathan@acm.org>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 1/7] GCOV: document behavior of -fkeep-{static,inline}-functions (PR gcov-profile/82633).
Date: Tue, 31 Oct 2017 11:12:00 -0000 [thread overview]
Message-ID: <f2eb7323-4191-4035-1d39-807816646c3e@suse.cz> (raw)
In-Reply-To: <fd7ed57c-d7a0-1f9d-daac-7f6aa845e28e@acm.org>
On 10/30/2017 01:15 PM, Nathan Sidwell wrote:
> On 10/26/2017 04:11 AM, marxin wrote:
>> gcc/ChangeLog:
>
>> +++ b/gcc/doc/gcov.texi
>> @@ -327,6 +327,11 @@ non-exceptional paths or only exceptional paths such as C++ exception
>> Â handlers, respectively. Given @samp{-a} option, unexecuted blocks are
>> Â marked @samp{$$$$$} or @samp{%%%%%}, depending on whether a basic block
>> Â is reachable via non-exceptional or exceptional paths.
>> +Note that GCC can perform function removal for functions obviously not
>> +used in a compilation unit. Such functions are marked with @samp{-}
>> +even though they contain a code. Use @option{-fkeep-inline-functions} and
>> +@option{-fkeep-static-functions} in order to properly
>> +record @var{execution_count} of such functions.
>
> This reads a little oddly. How about:
>
> Note that GCC can completely remove the bodies of functions that are not needed -- for instance if they are inlined everywhere. Such functions are marked with @samp{-}, which can be confusing. Use the @option{-fkeep-inline-functions} and @option{-fkeep-static-functions} options to retain these functions and allow gcov to properly show their @var{execution_count}.
Hi.
Thanks for rewriting that. Native speakers always produce more readable documentation.
I'll install your version as it is.
Martin
>
> Ok with that (or something approximating it).
>
> nathan
next prev parent reply other threads:[~2017-10-31 11:02 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 8:12 [PATCH 0/7] GCOV: another set of improvements marxin
2017-10-26 8:12 ` [PATCH 5/7] GCOV: std::vector refactoring marxin
2017-10-30 14:17 ` Nathan Sidwell
2017-10-26 8:12 ` [PATCH 1/7] GCOV: document behavior of -fkeep-{static,inline}-functions (PR gcov-profile/82633) marxin
2017-10-30 12:17 ` Nathan Sidwell
2017-10-31 11:12 ` Martin Liška [this message]
2017-10-26 8:12 ` [PATCH 4/7] GCOV: add -j argument (human readable format) marxin
2017-10-30 12:44 ` Nathan Sidwell
2017-10-31 11:54 ` Martin Liška
2017-10-31 12:10 ` Nathan Sidwell
2017-10-31 14:04 ` Martin Liška
2017-10-31 14:39 ` Nathan Sidwell
2017-10-31 15:33 ` Martin Liška
2017-10-26 8:12 ` [PATCH 2/7] GCOV: introduce usage of terminal colors marxin
2017-10-30 12:20 ` Nathan Sidwell
2017-10-30 14:53 ` David Malcolm
2017-10-31 11:14 ` Martin Liška
2017-10-26 8:12 ` [PATCH 3/7] GCOV: add support for lines with an unexecuted lines marxin
2017-10-30 12:27 ` Nathan Sidwell
2017-10-31 11:29 ` Martin Liška
2017-11-02 15:33 ` Eric Botcazou
2017-10-26 8:12 ` [PATCH 7/7] GCOV: std::vector refactoring III marxin
2017-10-30 14:23 ` Nathan Sidwell
2017-10-26 8:19 ` [PATCH 6/7] GCOV: Vector refactoring II marxin
2017-10-30 14:19 ` Nathan Sidwell
2017-10-26 8:47 ` [PATCH 8/N][RFC] GCOV: support multiple functions per a line Martin Liška
2017-10-26 12:06 ` Nathan Sidwell
2017-11-01 8:00 ` [PATCH 8/N][RFC] v2 " Martin Liška
2017-11-07 10:53 ` [PATCH 8/N][RFC][v3]: " Martin Liška
2017-11-07 15:09 ` Nathan Sidwell
2017-11-08 11:42 ` Martin Liška
2017-11-08 15:12 ` Nathan Sidwell
2017-11-09 9:47 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2eb7323-4191-4035-1d39-807816646c3e@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).