From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8031 invoked by alias); 31 Oct 2017 11:02:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 6951 invoked by uid 89); 31 Oct 2017 11:02:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=speakers, Hx-languages-length:1492, exceptional, HTo:D*acm.org X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 31 Oct 2017 11:02:47 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0FEFBABED; Tue, 31 Oct 2017 11:02:45 +0000 (UTC) Subject: Re: [PATCH 1/7] GCOV: document behavior of -fkeep-{static,inline}-functions (PR gcov-profile/82633). To: Nathan Sidwell , gcc-patches@gcc.gnu.org References: <22f49725f56049abf9bf99edd7e79728b180fad1.1509005504.git.mliska@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: Date: Tue, 31 Oct 2017 11:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg02299.txt.bz2 On 10/30/2017 01:15 PM, Nathan Sidwell wrote: > On 10/26/2017 04:11 AM, marxin wrote: >> gcc/ChangeLog: > >> +++ b/gcc/doc/gcov.texi >> @@ -327,6 +327,11 @@ non-exceptional paths or only exceptional paths such as C++ exception >>   handlers, respectively. Given @samp{-a} option, unexecuted blocks are >>   marked @samp{$$$$$} or @samp{%%%%%}, depending on whether a basic block >>   is reachable via non-exceptional or exceptional paths. >> +Note that GCC can perform function removal for functions obviously not >> +used in a compilation unit.  Such functions are marked with @samp{-} >> +even though they contain a code.  Use @option{-fkeep-inline-functions} and >> +@option{-fkeep-static-functions} in order to properly >> +record @var{execution_count} of such functions. > > This reads a little oddly.  How about: > > Note that GCC can completely remove the bodies of functions that are not needed -- for instance if they are inlined everywhere.  Such functions are marked with @samp{-}, which can be confusing.  Use the @option{-fkeep-inline-functions} and @option{-fkeep-static-functions} options to retain these functions and allow gcov to properly show their @var{execution_count}. Hi. Thanks for rewriting that. Native speakers always produce more readable documentation. I'll install your version as it is. Martin > > Ok with that (or something approximating it). > > nathan