From: Martin Sebor <msebor@gmail.com>
To: Jeff Law <law@redhat.com>, Richard Biener <richard.guenther@gmail.com>
Cc: Gcc Patch List <gcc-patches@gcc.gnu.org>
Subject: Re: [PING 2][PATCH] enhance -Wrestrict to handle string built-ins (PR 78918)
Date: Thu, 07 Dec 2017 21:28:00 -0000 [thread overview]
Message-ID: <f35dab70-5526-0b51-1650-7361606aa072@gmail.com> (raw)
In-Reply-To: <061c3f94-e943-71b1-a7e0-5fe5d324911a@redhat.com>
On 12/07/2017 02:14 PM, Jeff Law wrote:
> On 11/29/2017 04:36 PM, Martin Sebor wrote:
>> I've finished reimplementing the patch as a standalone pass.
>> In the attached revision I also addressed your comments below
>> as well as Richard's to allowing the strlen optimizations even
>> for overlapping accesses.
>>
>> While beefing up the tests I found a few minor issues that
>> I also fixed (false negatives).
>>
>> The fallout wasn't quite as bad as I thought, mainly thanks
>> to the narrow API for the checker.
> So still reading though this, but wanted to start with a question I hope
> you can answer quickly.
>
> In terms of coverage -- did we lose much in terms of cases that were
> diagnosed in the original version, but aren't in this version?
I'm quite pleased to say that with the pass in the right place
(after vrp) the coverage is the same.
Martin
next prev parent reply other threads:[~2017-12-07 21:28 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-16 23:47 [PATCH] " Martin Sebor
2017-07-20 20:46 ` Martin Sebor
2017-07-25 3:13 ` [PING] " Martin Sebor
2017-08-01 2:27 ` [PING #2] " Martin Sebor
2017-08-01 9:23 ` Richard Biener
2017-08-01 9:25 ` Richard Biener
2017-08-02 17:10 ` Jeff Law
2017-08-03 8:46 ` Richard Biener
2017-08-06 23:08 ` Martin Sebor
2017-08-08 13:08 ` Richard Biener
2017-08-09 16:14 ` Jeff Law
2017-08-22 2:04 ` Martin Sebor
2017-08-22 9:17 ` Richard Biener
2017-08-24 22:36 ` Jeff Law
2017-08-29 3:42 ` Martin Sebor
2017-09-01 15:15 ` Jeff Law
2017-08-29 2:35 ` Martin Sebor
2017-08-29 11:32 ` Richard Biener
[not found] ` <40984eff-b156-3315-7bb5-558e9e83bf6c@gmail.com>
2017-10-24 6:40 ` Martin Sebor
2017-11-10 0:28 ` [PING][PATCH] " Martin Sebor
2017-11-16 22:24 ` [PING 2][PATCH] " Martin Sebor
2017-11-23 0:16 ` Jeff Law
2017-11-26 9:12 ` Martin Sebor
2017-11-30 0:56 ` Martin Sebor
2017-12-07 21:14 ` Jeff Law
2017-12-07 21:28 ` Martin Sebor [this message]
2017-12-07 21:48 ` Jeff Law
2017-12-07 22:23 ` Jeff Law
2017-12-08 0:44 ` Martin Sebor
2017-12-08 19:19 ` Martin Sebor
2017-12-11 22:27 ` Jeff Law
2017-12-17 0:02 ` Martin Sebor
2017-12-17 13:32 ` H.J. Lu
2018-01-08 9:56 ` Tom de Vries
2017-12-07 20:16 ` Jeff Law
2017-11-27 12:45 ` Richard Biener
2017-11-30 1:19 ` Martin Sebor
2017-12-07 20:20 ` Jeff Law
2017-08-09 16:09 ` [PING #2] [PATCH] " Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f35dab70-5526-0b51-1650-7361606aa072@gmail.com \
--to=msebor@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).