public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: "Martin Liška" <mliska@suse.cz>, gcc-patches@gcc.gnu.org
Cc: Martin Sebor <msebor@gmail.com>
Subject: Re: [PATCH] strlen: do not use cond_expr for boundaries
Date: Tue, 27 Dec 2022 10:38:03 -0700	[thread overview]
Message-ID: <f393a5aa-58fd-4248-7f55-4483920a572c@gmail.com> (raw)
In-Reply-To: <677e6b2b-5198-f2b2-d5e5-dc388b77bcb0@suse.cz>



On 12/23/22 08:44, Martin Liška wrote:
> Hi.
> 
> We reach cond_expr and then we get an ICE in tree_int_cst_lt.
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
> 
> Ready to be installed?
> Thanks,
> Martin
> 
> 	PR tree-optimization/108137
> 
> gcc/ChangeLog:
> 
> 	* tree-ssa-strlen.cc (get_range_strlen_phi): Reject anything
> 	different from INTEGER_CST.
> 
> gcc/testsuite/ChangeLog:
> 
> 	* gcc.dg/tree-ssa/pr108137.c: New test.
OK.  You could perhaps do better by looking at the arms of the 
COND_EXPR, but this seems like the safest thing to do for gcc-13.

jeff

      reply	other threads:[~2022-12-27 17:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-23 15:44 Martin Liška
2022-12-27 17:38 ` Jeff Law [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f393a5aa-58fd-4248-7f55-4483920a572c@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mliska@suse.cz \
    --cc=msebor@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).