From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117563 invoked by alias); 16 Sep 2019 13:47:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 117554 invoked by uid 89); 16 Sep 2019 13:47:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=H*i:sk:nycvar., HContent-Transfer-Encoding:8bit X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Sep 2019 13:47:18 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 2C35AAFE8; Mon, 16 Sep 2019 13:47:16 +0000 (UTC) Subject: Re: [PATCH 3/5] Rewrite part of and_comparisons_1 into match.pd. To: Richard Biener Cc: gcc-patches@gcc.gnu.org, Li Jia He , Andrew Pinski , Jeff Law , Segher Boessenkool , wschmidt@linux.ibm.com, Martin Liska References: <1561615913-22109-1-git-send-email-helijia@linux.ibm.com> <845bc280-7bd6-509b-3830-4ebde50f1b20@linux.ibm.com> <4efa66d4-c04c-e5a6-18ff-2f4310d7f64d@suse.cz> <3b78e414-ff03-daa8-448f-4eaf766a2635@suse.cz> <8e67d843-c37b-06cd-52ea-943c97d58a87@suse.cz> <09b56054-cea4-a61d-f3b6-5d3ae1a92d75@suse.cz> <55116893-fd3b-1da4-ece2-952d97a49ce7@suse.cz> <9b2bcc34-6925-7623-9c46-f4704ebeab36@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: Date: Mon, 16 Sep 2019 13:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00944.txt.bz2 On 9/16/19 5:04 AM, Richard Biener wrote: > On Wed, 11 Sep 2019, Martin Liška wrote: > >> On 9/11/19 3:19 PM, Martin Liška wrote: >>> On 9/11/19 2:43 PM, Richard Biener wrote: >>>> Any particular reason you needed to swap the calls in >>>> maybe_fold_and/or_comparisons? > > You didn't answer this, besides that the patch is OK. Ah, sorry. No, there's not any particular reason. My motivation was that I moved the patterns from the beginning of and_comparisons_1 to match.pd. So that I wanted to begin with the maybe_fold_comparisons_from_match_pd. I'll put it back to the original order. Martin > > Thanks, > Richard. >