From: Andrew Stubbs <ams@codesourcery.com>
To: Kwok Cheung Yeung <kcy@codesourcery.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] [amdgcn] Add support for unordered floating-point comparisons
Date: Thu, 2 Apr 2020 16:36:08 +0100 [thread overview]
Message-ID: <f3a2834e-5322-fa4d-c1f9-9b1d162f1053@codesourcery.com> (raw)
In-Reply-To: <3ffcef54-43a4-022f-de36-fd8a5e068bab@codesourcery.com>
On 02/04/2020 15:55, Kwok Cheung Yeung wrote:
> Hello
>
> This patch adds support for the unordered floating-point comparison
> operators (UNEQ, UNGE, UNGT, UNLE, UNLT), which return true if one of
> the operands is a NaN. These comparisons can be generated by builtins
> such as __builtin_isgreater.
>
> GCC 10 appears to have a fall-back if the unordered comparisons are not
> available (by generating an unordered comparison first, followed by the
> main comparison), whereas previous versions would simply throw an ICE.
> Still, it should be a little more efficient to have direct support for
> these operators.
>
> Tested on a GCN3 board with no regressions noted. Okay for trunk?
OK, thanks.
Andrew
prev parent reply other threads:[~2020-04-02 15:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 14:55 Kwok Cheung Yeung
2020-04-02 15:36 ` Andrew Stubbs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3a2834e-5322-fa4d-c1f9-9b1d162f1053@codesourcery.com \
--to=ams@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kcy@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).