From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id A0FDE388A01C for ; Thu, 2 Apr 2020 15:36:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A0FDE388A01C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Andrew_Stubbs@mentor.com IronPort-SDR: /5nm9nZxAD3PAmR7zmIvCvByLZJD5mebZzE15pwWQsGpqeoc2vI6CLmP86IlvMeQPO+xw1jiOg 2earCIHzVMnjcRSzIRvLVX9E25ra70sPvl4m1JFhossjbnzGQa6mH/iFiQ/hqZphszO+DEBKz4 JKBp9jmAWlmkA9H6BMFqt43kw+ns3vgnTArnzDGMwONKJ+Fcf7UdS6S5A5rX7yW5bYBn0k3TfP fe1VYwIDZaS5qVGeGzZyX3w5gDrRyW0pFelx24hBW4vo4+k3yGvqgDs5VgciCTrDf3DMk6XzK4 ojM= X-IronPort-AV: E=Sophos;i="5.72,336,1580803200"; d="scan'208";a="47297340" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 02 Apr 2020 07:36:14 -0800 IronPort-SDR: 0uZG9NvV0qAD0pd9nFFaoRUgkuO1rehAfNrrINaAszWap5A8cafAwIqZTlX+tGzGlcqUKdguFx 6oKh67NTl7b8yTWIfoPT/g++JvE9XzfUTr4Xxwsebo2P2f+ExNH157pJQLCYLbWCWnjB9CL9fA FKAKN6T2WobIy9SJsP0U2ICJ0cWSseXZsfaUT8LSOUGIxUyRL6JrHnNl7L3Su4IZU9hShpDqdh yH5txB/EFDpC62yOLyiuhXswJgZmcZmLQ7VKRPmsdHXYwnxc/m982njY4PEurEFcevTnajHRbP 4wk= Subject: Re: [PATCH] [amdgcn] Add support for unordered floating-point comparisons To: Kwok Cheung Yeung , GCC Patches References: <3ffcef54-43a4-022f-de36-fd8a5e068bab@codesourcery.com> From: Andrew Stubbs Message-ID: Date: Thu, 2 Apr 2020 16:36:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <3ffcef54-43a4-022f-de36-fd8a5e068bab@codesourcery.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Apr 2020 15:36:17 -0000 On 02/04/2020 15:55, Kwok Cheung Yeung wrote: > Hello > > This patch adds support for the unordered floating-point comparison > operators (UNEQ, UNGE, UNGT, UNLE, UNLT), which return true if one of > the operands is a NaN. These comparisons can be generated by builtins > such as __builtin_isgreater. > > GCC 10 appears to have a fall-back if the unordered comparisons are not > available (by generating an unordered comparison first, followed by the > main comparison), whereas previous versions would simply throw an ICE. > Still, it should be a little more efficient to have direct support for > these operators. > > Tested on a GCN3 board with no regressions noted. Okay for trunk? OK, thanks. Andrew