From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id E60083858D35; Sun, 30 Apr 2023 19:46:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E60083858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-51f1b6e8179so1155037a12.3; Sun, 30 Apr 2023 12:46:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682883968; x=1685475968; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zZ85sJSJdcfmL/0DWegeHeMHD48nbOjciDFFFc8PEG4=; b=Wr5tnV66BXzi9A8QLjwEJsfvwYzfQrLwNguwpzjss6lOsWuTCX/GidiftwXtjldEvV MHlT+iLUC+dIY83uRpXbJzE6PIZf7X1utRLuOu5FVkXFEojNRR85ohvGRAnIXfdk4xrn cuoiEk2vIiRoAxOMTPdXHX0LZwZlrNAXDRmv7mLp80DM5S3aJRTtuD1YxctNXSBcmG4s eqVPp/iQpxVSWe3nkmSGM5/PxXmArtaPZnFmCbqZGMqJMoHNIQDat1uJoxZ/nFN0SyaA pi+4ZTmoUrS6DFYcnCM8aNaYvC1NbUxD+knFO4opDHBNVTGd7paQ0yZp2EMR1gUgvLmU qysA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682883968; x=1685475968; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zZ85sJSJdcfmL/0DWegeHeMHD48nbOjciDFFFc8PEG4=; b=gvzIP+lfXW0aC8aSbaNYwH6KfEXvrUqi9ATm/iU5/AsS5EFROcpSAVmStBLkFZ3bIv W4k126v3YlloUKI6+MrK34EWLybUNU/kiDCzduovVRPaeL2e1cYha1KApX9jgFdEj5WE QCbqk4wl1GuWaFSEoOFRQLhPu6J6JKG0mfskpuckGukWhT68jyVA4yy/97sem4ab9SqY LgX/CPRGmbYdm43SCaUcPd2vSpemT8V+hSP+j5Xi2o5LjSFTQ21UBCiwHGe9Vw6yeOXl Mwu3ddJaes9i2yq0FPX6L3mH05Zjua3SuFCtVrtUvQ17lG/h0cOgbLK02lKS742a3pMe g96Q== X-Gm-Message-State: AC+VfDyR6u4WZ9Xhs9P2QvRw+bjYyZxnElpv6hp3eimVNFJZDGOvx8l8 7gKtmIU1pBTAvoidMnGgfsk= X-Google-Smtp-Source: ACHHUZ7LfO4w0ffgUjaT5cpEnfgSLpgMqRYwlAPcq53sTWFjPt3N5dCCKkfi1JtOvywmUIvpsBol4A== X-Received: by 2002:a17:902:b203:b0:1a5:1f13:67fc with SMTP id t3-20020a170902b20300b001a51f1367fcmr11114825plr.31.1682883967601; Sun, 30 Apr 2023 12:46:07 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::99f? ([2601:681:8600:13d0::99f]) by smtp.gmail.com with ESMTPSA id c24-20020a170902849800b001a50ae08284sm16493200plo.301.2023.04.30.12.46.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Apr 2023 12:46:07 -0700 (PDT) Message-ID: Date: Sun, 30 Apr 2023 13:46:05 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 5/5] match.pd: Use splits in makefile and make configurable. Content-Language: en-US To: Tamar Christina , gcc-patches@gcc.gnu.org Cc: nd@arm.com, bonzini@gnu.org, neroden@gcc.gnu.org, aoliva@gcc.gnu.org, Ralf.Wildenhues@gmx.de References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/28/23 04:44, Tamar Christina via Gcc-patches wrote: > Hi All, > > This updates the build system to split up match.pd files into chunks of 10. > This also introduces a new flag --with-matchpd-partitions which can be used to > change the number of partitions. > > For the analysis of why 10 please look at the previous patch in the series. > > Bootstrapped Regtested on aarch64-none-linux-gnu and no issues. > > Ok for master? > > Thanks, > Tamar > > gcc/ChangeLog: > > PR bootstrap/84402 > * Makefile.in (NUM_MATCH_SPLITS, MATCH_SPLITS_SEQ, > GIMPLE_MATCH_PD_SEQ_SRC, GIMPLE_MATCH_PD_SEQ_O, > GENERIC_MATCH_PD_SEQ_SRC, GENERIC_MATCH_PD_SEQ_O): New. > (OBJS, MOSTLYCLEANFILES, .PRECIOUS): Use them. > (s-match): Split into s-generic-match and s-gimple-match. > * configure.ac (with-matchpd-partitions, > DEFAULT_MATCHPD_PARTITIONS): New. > * configure: Regenerate. This looks pretty reasonable to me. Are there any patches left in this series that need review? I'm very much looking forward to build time provements related to this patch, particularly for targets that I bootstrap with qemu emulation -- we take multiple hours to build gimple-match and the ability to parallelize those component builds should be a significant win. jeff