public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Stefan Agner <stefan@agner.ch>
To: nickc@redhat.com,	richard.earnshaw@arm.com,
	ramana.radhakrishnan@arm.com,	kyrylo.tkachov@arm.com
Cc: gcc-patches@gcc.gnu.org,	Stefan Agner <stefan@agner.ch>
Subject: [PATCH] ARM: fix -masm-syntax-unified (PR88648)
Date: Tue, 01 Jan 2019 23:34:00 -0000	[thread overview]
Message-ID: <f3d6816a30a0782d83cb3aa6ae1cc5231b80cd29.1546385382.git.stefan@agner.ch> (raw)

This allows to use unified asm syntax when compiling for the
ARM instruction. This matches documentation and seems what the
initial patch was intended doing when the flag got added.
---
 gcc/config/arm/arm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c
index 3419b6bd0f8..67b2b199f3f 100644
--- a/gcc/config/arm/arm.c
+++ b/gcc/config/arm/arm.c
@@ -3095,7 +3095,8 @@ arm_option_override_internal (struct gcc_options *opts,
 
   /* Thumb2 inline assembly code should always use unified syntax.
      This will apply to ARM and Thumb1 eventually.  */
-  opts->x_inline_asm_unified = TARGET_THUMB2_P (opts->x_target_flags);
+  if (TARGET_THUMB2_P (opts->x_target_flags))
+    opts->x_inline_asm_unified = true;
 
 #ifdef SUBTARGET_OVERRIDE_INTERNAL_OPTIONS
   SUBTARGET_OVERRIDE_INTERNAL_OPTIONS;
-- 
2.20.1

             reply	other threads:[~2019-01-01 23:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-01 23:34 Stefan Agner [this message]
2019-01-08  9:33 ` Kyrill Tkachov
2019-01-08  9:36   ` Kyrill Tkachov
2019-01-10 11:38   ` Kyrill Tkachov
2019-02-09 16:25     ` Stefan Agner
2019-02-11  9:27       ` Kyrill Tkachov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3d6816a30a0782d83cb3aa6ae1cc5231b80cd29.1546385382.git.stefan@agner.ch \
    --to=stefan@agner.ch \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=kyrylo.tkachov@arm.com \
    --cc=nickc@redhat.com \
    --cc=ramana.radhakrishnan@arm.com \
    --cc=richard.earnshaw@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).