From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id 74FFC3858417 for ; Tue, 28 Mar 2023 08:05:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 74FFC3858417 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x436.google.com with SMTP id i15so7376622pfo.8 for ; Tue, 28 Mar 2023 01:05:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679990724; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=toExlbVfhIR9JM2isBx+nnzv9TA0LCEBrjfoSTsT1C4=; b=g7AWjYVQcWKC+oq/hxU9kb1KHFvszYCt5EoHF0UN1blm5Ph9ta+w55vBwpFNEZQJv7 jheVPgW1ZjC06/Lkt+Er+1qoZ6ADOfDZUFBIwEqcsTs4wvH9pYVIhdca+jTV+P4iuu0N fHwk8e2hCgYwu+O+uyI5rb8tEQ09pUwCBE8nySYO4I6I6fhI8eimK1DZTwt/9/+Xr9mt Gt58/ku/zidgqQ4ODfHVuoNqwwSxCuwzRXQ++p90gwmfn9wJEAsywmIE9nFaVXWmJm9Q G3jjgLBPNfpaw41gNsRnue/tkLNubg1esDnefeIqzSJMG4vc5ak2706IHdxvR+9KYKpx 1lbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679990724; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=toExlbVfhIR9JM2isBx+nnzv9TA0LCEBrjfoSTsT1C4=; b=vzPPVlFLZHC/gXeaISTzF7IzeMOLXkuWVrM8f5cwxFA8VZ5grMvYBAWzHj3RErcg/r vJSn3XFBuZYjmiQdc8TxUTTpizoPRfkRqzJbatAocRzqJdr1j5MhM1wmIp1Ls1Y/aloA DgbuMsvjbgyztXReFWDtL5FhVOoMnIILooODit7Fwi5HCgDRheNvraHespVu2CjTYcBn Vb6Fz4+wrrYnFO+rBO1wZJaPskgN5bdeaF6p5JSOpR04QHF6ffCmJZ9IUoU2uOSi7C1P 4XXGGBb2iJBR1Vt2khsZqXZH2pAytm+KGcAL1eW9SS0dq6elU5OBJjZDoEMP2UFVaQGE Hv1A== X-Gm-Message-State: AAQBX9fECqKZUCZ4r7RErKyWREH6PE0xiGvtjBlXLJu9nKq8NtkR3k9f 5L780Fjd7yZT/z2y/bEztfQ= X-Google-Smtp-Source: AKy350bn6uRnKOYTYKcncum3YjoQubCbI4eUZtnQqIMhbZO3okIB4vK2yd4vNdPCof7WBGa70hhHCg== X-Received: by 2002:a62:4e05:0:b0:5cb:eecd:387b with SMTP id c5-20020a624e05000000b005cbeecd387bmr12580036pfb.33.1679990724398; Tue, 28 Mar 2023 01:05:24 -0700 (PDT) Received: from ?IPV6:2001:f40:91b::485? ([2001:f40:91b::485]) by smtp.gmail.com with ESMTPSA id g23-20020a63f417000000b0050bd9c8c53dsm19317702pgi.23.2023.03.28.01.05.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Mar 2023 01:05:23 -0700 (PDT) Message-ID: Date: Tue, 28 Mar 2023 08:05:21 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: Enable UTF-8 code page in driver and compiler on 64-bit mingw host [PR108865] Content-Language: en-US To: Costas Argyris , gcc-patches@gcc.gnu.org Cc: Jacek Caban References: <508051a3-0314-bb4a-1ce8-5772b1b8f5a6@codeweavers.com> <002e2259-1859-1f77-ffa0-40b1b673dd4f@gmail.com> From: Jonathan Yong <10walls@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3031.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/27/23 17:17, Costas Argyris wrote: > The patch attached to this email extends the UTF-8 support of the > driver and compiler processes to the 32-bit mingw host. Initially, > only the 64-bit host got it. > > About the changes in sym-mingw32.cc: > > Even though the 64-bit host was building fine with the symbol being > simply declared as a char, the 32-bit host was failing to find the > symbol at link time because a leading underscore was being added > to it by the compiler. The asm keyword ensures that the symbol > always appears with that exact name, such that the linker will > always find it. > > The patch also includes Jacek's flag about adding the .manifest file > as a prerequisite for the object file (this was actually done from before > but an earlier version of the patch was pushed so it was missed). > > Tested building from master for both 32 and 64-bit mingw hosts using: > > 1) cross-compilation from a Debian machine using configure + make > 2) native-compilation from a Windows machine using MSYS2 > Thanks, approved and pushed to master branch.