From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96095 invoked by alias); 19 Oct 2016 14:45:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 95905 invoked by uid 89); 19 Oct 2016 14:45:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:657, H*MI:sk:1476822, H*i:sk:1476822, H*f:sk:1476822 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Oct 2016 14:45:13 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 92FF94E4D9; Wed, 19 Oct 2016 14:45:12 +0000 (UTC) Received: from localhost.localdomain (vpn1-6-98.ams2.redhat.com [10.36.6.98]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9JEjA1R016067; Wed, 19 Oct 2016 10:45:11 -0400 Subject: Re: [PATCH 09/16] Split class rtx_reader into base_rtx_reader vs rtx_reader To: David Malcolm , gcc-patches@gcc.gnu.org References: <1475684110-2521-1-git-send-email-dmalcolm@redhat.com> <1475684110-2521-10-git-send-email-dmalcolm@redhat.com> <2296dd4b-cf1e-8fca-2df3-092aad7dc575@redhat.com> <1476822633.10766.69.camel@redhat.com> Cc: Richard Sandiford From: Bernd Schmidt Message-ID: Date: Wed, 19 Oct 2016 14:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1476822633.10766.69.camel@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg01550.txt.bz2 On 10/18/2016 10:30 PM, David Malcolm wrote: > > I'm not in love with the names I chose in this patch. It does seem odd > having an "rtx_reader" class that can't actually read hierarchical rtx. > > How about "md_reader" as the base class (with responsibility for the > things in read-md.o), and "rtx_reader" for the subclass (adding the > things in read-rtl.o)? I think a lot of renaming was for a variable (base_rtx_reader_ptr), not the class, wasn't it? I would very much like to avoid these, but I think for the class names it should be ok to go with what you suggest. Bernd