From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 35DB03858438 for ; Wed, 28 Sep 2022 07:29:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 35DB03858438 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.20.4.52] (unknown [10.20.4.52]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxX+C99zNj+SojAA--.1088S2; Wed, 28 Sep 2022 15:29:01 +0800 (CST) Subject: Re: [PATCH v2] LoongArch: Libvtv add loongarch support. To: Xi Ruoyao , gcc-patches@gcc.gnu.org, mliska@suse.cz, dmalcolm@redhat.com, Caroline Tice Cc: xuchenghua@loongson.cn, i@xen0n.name, qijingwen References: <20220927074928.804896-1-chenglulu@loongson.cn> <94830aafc09b8cfd809b7a29163377842112112b.camel@xry111.site> From: Lulu Cheng Message-ID: Date: Wed, 28 Sep 2022 15:29:01 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <94830aafc09b8cfd809b7a29163377842112112b.camel@xry111.site> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8DxX+C99zNj+SojAA--.1088S2 X-Coremail-Antispam: 1UD129KBjvdXoWruFy8Xw15uF13Xr1xurW3KFg_yoWfXrX_WF s8WrZ3uwn7JayDur4qqF1FvFsrt34jvryfZw4DuF4xWryUWas5Jrn5G3y5Jws8KrsIqrZ5 Xr4YgrW2k3ZFgjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbIAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j 6F4UJwA2z4x0Y4vEx4A2jsIE14v26F4UJVW0owA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvEwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7I2V7IY0VAS07AlzVAY IcxG8wCY02Avz4vE-syl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2 IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v2 6r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2 IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv 67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyT uYvjfUoOJ5UUUUU X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,BODY_8BITS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: 在 2022/9/27 下午7:44, Xi Ruoyao 写道: > On Tue, 2022-09-27 at 15:49 +0800, Lulu Cheng wrote: >>  #if defined (__CYGWIN__) || defined (__MINGW32__) >>    if (VTV_PAGE_SIZE != sysconf_SC_PAGE_SIZE()) >> +#elif defined (__loongarch_lp64) >> +  /* I think that under the LoongArch 64-bit system, VTV_PAGE_SIZE is set >> +     to the maximum value of 64K supported by the system, so there is no >> +     need to judge here.  */ >> +  if (false) > I think "if (false)" can trigger some compiler warnings... > > Still not sure if the maximum value is always correct (+ Caroline for a > confirmation). If it's correct I'd suggest... > >>  #else >>    if (VTV_PAGE_SIZE != sysconf (_SC_PAGE_SIZE)) > if (VTV_PAGE_SIZE % sysconf (_SC_PAGE_SIZE) != 0) If the setting to the maximum value is correct, I also think it is better to achieve this. > >>  #endif