From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18760 invoked by alias); 19 Aug 2019 20:43:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 18751 invoked by uid 89); 19 Aug 2019 20:43:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Aug 2019 20:43:35 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 643BB18ABC23; Mon, 19 Aug 2019 20:43:34 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-5.rdu2.redhat.com [10.10.112.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9F0BE5D9C3; Mon, 19 Aug 2019 20:43:33 +0000 (UTC) Subject: Re: [08/13] Use function_arg_info for TARGET_CALLEE_COPIES To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com References: From: Jeff Law Openpgp: preference=signencrypt Message-ID: Date: Mon, 19 Aug 2019 21:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg01351.txt.bz2 On 8/19/19 9:19 AM, Richard Sandiford wrote: > Use function_arg_info for TARGET_CALLEE_COPIES. > > The hook is passed the unpromoted type mode instead of the promoted mode. > > The aarch64 definition is redundant, but worth keeping for emphasis. > > > 2019-08-19 Richard Sandiford > > gcc/ > * target.def (callee_copies): Take a function_arg_info instead > of a mode, type and named flag. > * doc/tm.texi: Regenerate. > * targhooks.h (hook_callee_copies_named): Take a function_arg_info > instead of a mode, type and named flag. > (hook_bool_CUMULATIVE_ARGS_mode_tree_bool_false): Delete. > (hook_bool_CUMULATIVE_ARGS_mode_tree_bool_true): Likewise. > (hook_bool_CUMULATIVE_ARGS_arg_info_true): New function. > * targhooks.c (hook_callee_copies_named): Take a function_arg_info > instead of a mode, type and named flag. > (hook_bool_CUMULATIVE_ARGS_mode_tree_bool_false): Delete. > (hook_bool_CUMULATIVE_ARGS_mode_tree_bool_true): Likewise. > (hook_bool_CUMULATIVE_ARGS_arg_info_true): New function. > * calls.h (reference_callee_copied): Take a function_arg_info > instead of a mode, type and named flag. > * calls.c (reference_callee_copied): Likewise. > (initialize_argument_information): Update call accordingly. > (emit_library_call_value_1): Likewise. > * function.c (gimplify_parameters): Likewise. > * config/aarch64/aarch64.c (TARGET_CALLEE_COPIES): Define to > hook_bool_CUMULATIVE_ARGS_arg_info_false instead of > hook_bool_CUMULATIVE_ARGS_mode_tree_bool_false. > * config/c6x/c6x.c (c6x_callee_copies): Delete. > (TARGET_CALLEE_COPIES): Define to > hook_bool_CUMULATIVE_ARGS_arg_info_true instead. > * config/epiphany/epiphany.c (TARGET_CALLEE_COPIES): Define to > hook_bool_CUMULATIVE_ARGS_arg_info_true instead of > hook_bool_CUMULATIVE_ARGS_mode_tree_bool_true. > * config/mips/mips.c (mips_callee_copies): Take a function_arg_info > instead of a mode, type and named flag. > * config/mmix/mmix.c (TARGET_CALLEE_COPIES): Define to > hook_bool_CUMULATIVE_ARGS_arg_info_true instead of > hook_bool_CUMULATIVE_ARGS_mode_tree_bool_true. > * config/mn10300/mn10300.c (TARGET_CALLEE_COPIES): Likewise. > * config/msp430/msp430.c (msp430_callee_copies): Delete. > (TARGET_CALLEE_COPIES): Define to > hook_bool_CUMULATIVE_ARGS_arg_info_true instead. > * config/pa/pa.c (pa_callee_copies): Take a function_arg_info > instead of a mode, type and named flag. > * config/sh/sh.c (sh_callee_copies): Likewise. > * config/v850/v850.c (TARGET_CALLEE_COPIES): Define to > hook_bool_CUMULATIVE_ARGS_arg_info_true instead of > hook_bool_CUMULATIVE_ARGS_mode_tree_bool_true. > OK jeff