From: Jeff Law <jeffreyalaw@gmail.com>
To: Mark Harmstone <mark@harmstone.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 11/11] Handle subroutine types in CodeView
Date: Tue, 25 Jun 2024 20:27:08 -0600 [thread overview]
Message-ID: <f4a354b6-21b1-4e20-bb4d-33b9b9f4431a@gmail.com> (raw)
In-Reply-To: <20240618001713.24034-12-mark@harmstone.com>
On 6/17/24 6:17 PM, Mark Harmstone wrote:
> Translates DW_TAG_subroutine_type DIEs into LF_PROCEDURE symbols.
>
> gcc/
> * dwarf2codeview.cc
> (struct codeview_custom_type): Add lf_procedure and lf_arglist
> to union.
> (write_lf_procedure, write_lf_arglist): New functions.
> (write_custom_types): Call write_lf_procedure and
> write_lf_arglist.
> (get_type_num_subroutine_type): New function.
> (get_type_num): Handle DW_TAG_subroutine_type DIEs.
> * dwarf2codeview.h (LF_PROCEDURE, LF_ARGLIST): Define.
THanks. I've pushed this to the trunk.
That's the main patchkit. Just minor follow-up items when you can get
them done.
I think the bigger question here is whether or not you're likely to do
significant additional work here or elsewhere in GCC. If so, we should
probably get you write privs. If not, we can continue having myself or
someone else handle committing patches for you.
Jeff
prev parent reply other threads:[~2024-06-26 2:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 0:17 [PATCH 00/11] CodeView variables and type system Mark Harmstone
2024-06-18 0:17 ` [PATCH 01/11] Output CodeView data about variables Mark Harmstone
2024-06-23 23:50 ` Jeff Law
2024-06-18 0:17 ` [PATCH 02/11] Handle CodeView base types Mark Harmstone
2024-06-24 0:18 ` Jeff Law
2024-06-18 0:17 ` [PATCH 03/11] Handle typedefs for CodeView Mark Harmstone
2024-06-24 0:30 ` Jeff Law
2024-06-18 0:17 ` [PATCH 04/11] Handle pointers " Mark Harmstone
2024-06-24 3:31 ` Jeff Law
2024-06-18 0:17 ` [PATCH 05/11] Handle const and varible modifiers " Mark Harmstone
2024-06-24 3:39 ` Jeff Law
2024-06-25 2:49 ` Mark Harmstone
2024-06-25 5:42 ` Jeff Law
2024-06-18 0:17 ` [PATCH 06/11] Handle enums " Mark Harmstone
2024-06-24 3:49 ` Jeff Law
2024-06-18 0:17 ` [PATCH 07/11] Handle structs and classes " Mark Harmstone
2024-06-25 5:40 ` Jeff Law
2024-06-18 0:17 ` [PATCH 08/11] Handle unions " Mark Harmstone
2024-06-25 23:29 ` Jeff Law
2024-06-18 0:17 ` [PATCH 09/11] Handle arrays " Mark Harmstone
2024-06-25 23:32 ` Jeff Law
2024-06-18 0:17 ` [PATCH 10/11] Handle bitfields " Mark Harmstone
2024-06-26 2:21 ` Jeff Law
2024-06-18 0:17 ` [PATCH 11/11] Handle subroutine types in CodeView Mark Harmstone
2024-06-26 2:27 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4a354b6-21b1-4e20-bb4d-33b9b9f4431a@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mark@harmstone.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).