From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [81.169.146.216]) by sourceware.org (Postfix) with ESMTPS id 499AB3858C54; Sun, 18 Sep 2022 17:40:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 499AB3858C54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gjlay.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=gjlay.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1663522801; s=strato-dkim-0002; d=gjlay.de; h=Subject:From:Cc:To:Date:Message-ID:Cc:Date:From:Subject:Sender; bh=EUiNHyBnTqq6mSdtRosHl7TDihYd3ftdFnqynOZEsIA=; b=rAW8yBu7OEGKFjISmKKXrget+ZLApazwg2lgT11tSHl6lvXYtB1nVCkPFMuNECF1S8 8HARWWQ6gJEV/tJ6gHUJgDzbXvkO4guiuSlyt/djDaN1cSP0XMBFz4uJxzPNlHBChNID Hp4FYjJUVof+zKtz2cdCmzTECZFPZOxwopUVIjj+OrIoqmcy/zf0bBuCMkhaoz6FTseJ 6iQBPvJWjmrK/axskoZXKf7ftaefhL6sopfpcZO6NqEclsNLh7Z1EFP1YJ9XYb8xwurr MPJHP7g2p1YZBCwp9LgPVrIjVNcqrEwuT43kOmEquaS6fnvWMkvbTyuIST1ziz3RCRnB EJTQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":LXoWVUeid/7A29J/hMvvT3koxZnKT7Qq0xotTetVnKkbjtK7qmy9Jvpc5Ezo" X-RZG-CLASS-ID: mo00 Received: from [192.168.2.102] by smtp.strato.de (RZmta 48.1.0 DYNA|AUTH) with ESMTPSA id 6f8f00y8IHe1WH7 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Sun, 18 Sep 2022 19:40:01 +0200 (CEST) Content-Type: multipart/mixed; boundary="------------S74nCK1v5omnmt6ekAEIiPMr" Message-ID: Date: Sun, 18 Sep 2022 19:39:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 To: gcc-patches@gcc.gnu.org Content-Language: en-US Cc: Jeff Law , Senthil Kumar Selvaraj From: Georg Johann Lay Subject: [patch,avr] Fix PR target/99184: Wrong cast from double to 16-bit and 32-bit ints. X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------S74nCK1v5omnmt6ekAEIiPMr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello, this patch fixed PR target/99184 which incorrectly rounded during 64-bit (long) double to 16-bit and 32-bit integers. The patch just removes the respective roundings from libf7-asm.sx::to_integer and ::to_unsigned. Luckily, LibF7 does nowhere use respective functions internally, the only user is in libf7.c::f7_exp which reads f7_round (qq, qq); int16_t q = f7_get_s16 (qq); so that f7_get_s16() operates on an already rounded value, and therefore this code works unaltered with or without rounding in to_integer. The patch applies to directory ./libgcc/config/avr/libf7/ and is the same for all GCC versions v10+. Please someone with write permissions commit it to trunk and backport to v12, v11, and v10 as it is a wrong-code issue. The patch will fit without problems (except for ChangeLog) because there is no traffic on that folder. Thanks, Johann libgcc/config/avr/libf7/ PR target/99184 Remove rounding from double to [u]int16 and [u]int32 casts. * libf7-asm.sx (to_integer, to_unsigned): Don't round 16-bit and 32-bit integers. --------------S74nCK1v5omnmt6ekAEIiPMr Content-Type: text/x-patch; charset=UTF-8; name="pr99184.diff" Content-Disposition: attachment; filename="pr99184.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA3ZTA2ZjUyLi4zZWMw MDgyIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTAgQEAKKworCVBSIHRhcmdldC85OTE4NAorCVJlbW92ZSByb3VuZGluZyBmcm9tIGRvdWJs ZSB0byBbdV1pbnQxNiBhbmQgW3VdaW50MzIgY2FzdHMuCisKKwkqIGxpYmY3LWFzbS5zeCAo dG9faW50ZWdlciwgdG9fdW5zaWduZWQpOiBEb24ndCByb3VuZCAxNi1iaXQKKwlhbmQgMzIt Yml0IGludGVnZXJzLgorCiAyMDIyLTA0LTIxICBSZWxlYXNlIE1hbmFnZXIKIAogCSogR0ND IDExLjMuMCByZWxlYXNlZC4KZGlmZiAtLWdpdCBhL2xpYmY3LWFzbS5zeCBiL2xpYmY3LWFz bS5zeAppbmRleCA3NjI5ZTIzLi45ZDcwMWYyIDEwMDY0NAotLS0gYS9saWJmNy1hc20uc3gK KysrIGIvbGliZjctYXNtLnN4CkBAIC02MDEsOSArNjAxLDYgQEAgREVGVU4gdG9faW50ZWdl cgogICAgIHRzdCAgICAgQzYKICAgICBicm1pICAgIC5Mc2F0dXJhdGUuVCAgICA7ICAgPiBJ TlR4eF9NQVggID0+ICBzYXR1cmF0ZQogCi0gICAgcmNhbGwgICAuTHJvdW5kCi0gICAgYnJt aSAgICAuTHNhdHVyYXRlLlQgICAgOyAgID4gSU5UeHhfTUFYICA9PiAgc2F0dXJhdGUKLQog ICAgIGJydGMgOWYgICAgICAgICAgICAgICAgIDsgICA+PSAwICAgICAgICAgPT4gIHJldHVy bgogICAgIHNicmMgICAgTWFzaywgICA1CiAgICAgLmdsb2JhbCBfX25lZ2RpMgpAQCAtNjU4 LDMwICs2NTUsNiBAQCBERUZVTiB0b19pbnRlZ2VyCiAgICAgLmdsb2JhbCBfX2Nscl84CiAg ICAgWEpNUCAgICBfX2Nscl84CiAKLS5Mcm91bmQ6Ci0gICAgOzsgQzYuNyBpcyBrbm93biB0 byBiZSAwIGhlcmUuCi0gICAgOzsgUmV0dXJuIE4gPSAxIGlmZiB3ZSBoYXZlIHRvIHNhdHVy YXRlLgotICAgIGNwaSAgICAgTWFzaywgICAweGYKLSAgICBicmVxIC5Mcm91bmQxNgotICAg IGNwaSAgICAgTWFzaywgICAweDFmCi0gICAgYnJlcSAuTHJvdW5kMzIKLQotICAgIDs7IEZv ciBub3csIG5vIHJvdW5kaW5nIGluIHRoZSA2NC1iaXQgY2FzZS4gIFRoaXMgcm91bmRpbmcK LSAgICA7OyB3b3VsZCBoYXZlIHRvIGJlIGludGVncmF0ZWQgaW50byB0aGUgcmlnaHQtc2hp ZnQuCi0gICAgY2xuCi0gICAgcmV0Ci0KLS5Mcm91bmQzMjoKLSAgICByb2wgICAgIEMyCi0g ICAgYWRjICAgICBDMywgICAgIFpFUk8KLSAgICBhZGMgICAgIEM0LCAgICAgWkVSTwotICAg IHJqbXAgMmYKLQotLkxyb3VuZDE2OgotICAgIHJvbCAgICAgQzQKLTI6ICBhZGMgICAgIEM1 LCAgICAgWkVSTwotICAgIGFkYyAgICAgQzYsICAgICBaRVJPCi0gICAgcmV0CiBFTkRGIHRv X2ludGVnZXIKICNlbmRpZiAvKiBGN01PRF90b19pbnRlZ2VyXyAqLwogCkBAIC03MjUsMjkg KzY5OCw2IEBAIERFRlVOIHRvX3Vuc2lnbmVkCiAgICAgY2xyICAgICBDQQogICAgIEY3Y2Fs bCAgbHNocmRpMwogICAgIFBPUCAgICAgcjE2Ci0KLSAgICA7OyBSb3VuZGluZwotICAgIDs7 ID8/PyBDNi43IGlzIGtub3duIHRvIGJlIDAgaGVyZS4KLSAgICBjcGkgICAgIE1hc2ssICAg MHhmCi0gICAgYnJlcSAuTHJvdW5kMTYKLSAgICBjcGkgICAgIE1hc2ssICAgMHgxZgotICAg IGJyZXEgLkxyb3VuZDMyCi0KLSAgICA7OyBGb3Igbm93LCBubyByb3VuZGluZyBpbiB0aGUg NjQtYml0IGNhc2UuICBUaGlzIHJvdW5kaW5nCi0gICAgOzsgd291bGQgaGF2ZSB0byBiZSBp bnRlZ3JhdGVkIGludG8gdGhlIHJpZ2h0LXNoaWZ0LgotICAgIHJldAotCi0uTHJvdW5kMzI6 Ci0gICAgcm9sICAgICBDMgotICAgIGFkYyAgICAgQzMsICAgICBaRVJPCi0gICAgYWRjICAg ICBDNCwgICAgIFpFUk8KLSAgICByam1wIDJmCi0KLS5Mcm91bmQxNjoKLSAgICByb2wgICAg IEM0Ci0yOiAgYWRjICAgICBDNSwgICAgIFpFUk8KLSAgICBhZGMgICAgIEM2LCAgICAgWkVS TwotICAgIGJyY3MgICAgLkxzZXRfMHhmZmZmICAgIDsgUm91bmRpbmcgb3ZlcmZsb3cgID0+ ICBzYXR1cmF0ZQogICAgIHJldAogCiAuTHNldF8weGZmZmY6Cg== --------------S74nCK1v5omnmt6ekAEIiPMr--