From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by sourceware.org (Postfix) with ESMTPS id 100543858C83; Mon, 17 Oct 2022 17:31:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 100543858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1666027904; bh=af49+8+ZeYt783jSjwxNlFyv8X5FoWJkMyrKOxlldnI=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=COwojkQBP4r3hNo+1G4JBrUWSoKgy+ihd+7wHIhuuCxkOtXJMa6arTeBUpf7I0EgI 368W6L187iHNP03cr5HpiLf/HO4c/F54EdLB/uMW0jDGeNW1LzfbRPpZOGjhxPAByC 6j44+/YwnO5TjkTbeIZ4MasFZnxAGJ3F8U7rYkhQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.178.29] ([93.207.88.170]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MG9kC-1ouPbY0U7I-00GVkg; Mon, 17 Oct 2022 19:31:44 +0200 Message-ID: Date: Mon, 17 Oct 2022 19:31:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH, v2] Fortran: handle bad array ctors with typespec [PR93483, , PR107216, PR107219] To: Mikael Morin , fortran@gcc.gnu.org Cc: gcc-patches@gcc.gnu.org Newsgroups: gmane.comp.gcc.fortran,gmane.comp.gcc.patches References: <01143700-424c-ba84-6e95-c8b3573741f5@orange.fr> Content-Language: en-US From: Harald Anlauf In-Reply-To: <01143700-424c-ba84-6e95-c8b3573741f5@orange.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:2/wr/CnPLieICPE9TdJKM9C1i1e0HIAW+w9805bs4GSr0XhTTqi +tPnXlbwwF1/yI1ezcD/ynDePPA5Qud3TKG/2vaCon3JY9NGq3N36EMIBpQxJWrbSlq2w+O r6w/Sv4A/G+uPvNPBRI+nxCpctePkYr/rECdz9PsoFvjx4txSQsRduvbs7AEboO2JOSzt8T biufyZdCQ2knFtJ1cYiVQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:1kl9Dk4xW2U=:TBlas9nw8fm3KqAya2jqWf bSw+3Z3XXQoCAE0KIsh5oTYFUHyHhjtnoW+Ev7TdZjP6tBSIFZYFT6Zi6YgjdxmZtIkZYxjT+ z8P0zrRMI2X26HKThq00Eoc29g97LcK6VcnQQbcnXBIZqMOec9n799Lx344PQvU+VLOp5Tnyd iPAGcfobg5pifU1oU5MfEnqekIyr0uJQ8Xj2TlDWsXG828P8fR8jP1zzifk3qejLcS81h2bVa sfFKJqsx4TvgHZiEa0vSPMM5bhHPRz2k3PJAv1t5d4+hm6SfjQBwfNPAoHjgqG2JJjzVuX/CF r1KElzcBojMvoRkgSzn3VJFNgIXy9HMnynStgMMzz4xV9b7MW9u0LtNHMp5GPOKHgpdQ2Q2fg bYgX7Sqk1Eiq5+XrpfLQ8+QK6VDvmSiRAe2joh8CFPvBgueAHfXrgdhDyJbju7TYiM3SiHdq/ b7Vzt6We3dDhutZCmXKqsHSnPHwtkGZPKfOTxtZgJdX7X4SHuZVDTBcOIsU1w+e8KXYt1NjWi VyG3QDoTAXmSrd0tcZ6Dl9ZwOUlPQtARyq+FdUJwc5oMGg5M+nE6iTHoYaGBRcDQ6lmziit4q OQpT0B0+c0fGx2t2LVWIzsQ6LWRozEFwRjXHgHITb4YzUlz33zdBw/5M5d1qg40Eb9WCneFAe gvK8HDpJf8Lt4o9quV27qUa3zVhHoJUdQ6E5Qyll8kM/LLqs5h6N2MQ3Fh8rxDGzCuogCH2yB nfoEy9ll3AIC+d8Rn4tUv+GzBnLDzoMBrIsQij3qX41PklLlLNq/Prvh1FypOC8bFz1YLL73b rFycFhgBa/qwAK5YRnB6f26F39TOKKjkm4H8ie8ypFm80FmN6knHoF1swbngkJu5Mt5xL34pr tdS25M7AIoSUR8ctqeadPVnOC4699XHXimVfKvUmzj451ui3M5/DpR1BVcqc29Y46rYZLpcHn psXOMF4wqePIk1Z7IpJ6IFRvjrVvdf2gXMnGYFvPXMMl10+MI0cHZ1hA/FXx6MW5vRIbtDuxo iSMB+bzxaaH3HS3pKH/HwyUoUgaXoLVKu8kJF6QrSYkL9asTUj92u4K4Sg45Ihj0A9bjTn+5f xlu89GGVqU9cXQ5WVEN+AEs5WJiTfRaQ6masRmrEPPAgWxu/M25r12+n/GmlsfmiUgX4fCREC 1dyyCYrxRttSG+dsFBqhdlyFCggaDNx1B+BTu1PQG7zNV/vPDlPP580oPF/gmh/pV8M6+zcIR E9yKheMh0p/+CTW08Ced4OQAwGfBFOTqclVdQYk6usc/ev3VZy7ZvwCk9/pL3Lnwy3eVV4l++ Ic66YExtp8Q85y8dGiDrayX/+/1MEmyftZzxyQBP8juR/cquRfTC6iZOu6rzc3wSJxCJo31n4 9hmbtcss7r8XbdNrf/sgaGFgCTWNnv6F6Gf1xwg8p1eXKwSPHOlKcRoE/LBIjwqSpSpkpkt2O kJgztlpw1qc1nV3HgCAWMnY4zfbyQT4uL4qb6ge8l6Mnoh7WLrG/zRFvY9sM9QpaBfi5ifcvw /MioUWi6gmB21+/rDOHIyTkYjI2dBcAi5jPScxyU1zHHV X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Mikael, Am 16.10.22 um 23:17 schrieb Mikael Morin: > Le 15/10/2022 =C3=A0 22:15, Harald Anlauf via Fortran a =C3=A9crit=C2=A0= : >> Dear all, >> >> here is an updated version of the patch that includes suggestions >> and comments by Mikael in PR93483. >> >> Basic new features are: >> - a new enum value ARITH_NOT_REDUCED to keep track if we encountered >> =C2=A0=C2=A0 an expression that was not reduced via reduce_unary/reduce= _binary >> - a cleanup of the related checking, resulting in more readable >> =C2=A0=C2=A0 code. >> - a new testcase by Mikael that exhibited a flaw in the first patch >> =C2=A0=C2=A0 due to a false resolution of a symbol by premature simplif= ication. >> >> Regtested again.=C2=A0 OK for mainline? >> > (...) >> diff --git a/gcc/fortran/gfortran.h b/gcc/fortran/gfortran.h >> index 10bb098d136..7b8f0b148bd 100644 >> --- a/gcc/fortran/gfortran.h >> +++ b/gcc/fortran/gfortran.h >> @@ -222,11 +222,12 @@ enum gfc_intrinsic_op >> =C2=A0=C2=A0=C2=A0 Assumptions are made about the numbering of the inte= rface_op >> enums.=C2=A0 */ >> =C2=A0#define GFC_INTRINSIC_OPS GFC_INTRINSIC_END >> >> -/* Arithmetic results.=C2=A0 */ >> +/* Arithmetic results.=C2=A0 ARITH_NOT_REDUCED is used to keep track o= f >> failed >> +=C2=A0=C2=A0 reductions because an erroneous expression was encountere= d.=C2=A0 */ > > The expressions are not always erroneous.=C2=A0 They can be, but in the > testcase for example, all the expressions are valid.=C2=A0 They are just > unsupported by the arithmetic evaluation code which works only with > literal constants and arrays of literal constants (and arrays of arrays > etc). > > OK with that comment fixed. you're absolutely right. I adjusted the comment and the commit message according to your suggestion. Pushed as https://gcc.gnu.org/g:d45af5c2eb1ba1e48449d8f3c5b4e3994a956f92 Thanks, Harald > Thanks. >