From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by sourceware.org (Postfix) with ESMTPS id 2A659394341E for ; Fri, 11 Jun 2021 14:46:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2A659394341E Received: by mail-ot1-x32a.google.com with SMTP id l15-20020a05683016cfb02903fca0eacd15so3356955otr.7 for ; Fri, 11 Jun 2021 07:46:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uSBcwsUWskMVuLvSqZG03IB4j4aJxNgl7Kc3izQ0y34=; b=bRPXBPm3YXkB6JiFUqiOZMAeqFHFVvTq43nnlPlAMnF1wwscnYvUieb2STlPankUYL OGu49lrZuhYmGOvECQZ8MbBNWkfnAYohmK52VjMnKTBGvAuJBoGcUjMbDdLT/EFUNQat Zlxc5q1HOyIBQ/H4yh4on0hS5Ugv0henfz3ivhibnK7WyqdGD1pJE50bboiAUop5Bv1J +8Q5Zs15Iel/tOe/ZTSf/x2OuceO1Wi7poni3KumCCIQHW5FEHBfOa6RZ53YoCZreEk9 JbFdFZfnD/8t+biWFQwWP+UyLcmVo7lheNSMlOFkArNLsYkz8GZCIQHLH7cPy51SAeLF Sa2w== X-Gm-Message-State: AOAM532OdnfLLQH2TkeP5Qt/6770KwMqHIi4hD2JNvH/SPn2PHwstK89 4X+con8gljKj++gEOXh9cSU= X-Google-Smtp-Source: ABdhPJxIlrW1sYG0VLQQJjlewgrI3x9STFWjXh/eLslljjWZlqR3eeT1sexkwD+AGtANAkCF4VFYjg== X-Received: by 2002:a9d:475:: with SMTP id 108mr3436009otc.69.1623422771622; Fri, 11 Jun 2021 07:46:11 -0700 (PDT) Received: from [192.168.0.41] (97-118-122-241.hlrn.qwest.net. [97.118.122.241]) by smtp.gmail.com with ESMTPSA id o26sm1357085otk.77.2021.06.11.07.46.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jun 2021 07:46:11 -0700 (PDT) Subject: Re: [PATCH 3/4] remove %K from error() calls in the aarch64/arm back ends (PR 98512) To: Martin Sebor via Gcc-patches , richard.sandiford@arm.com References: <2e49b6c6-a403-a207-c41e-58f78df96b84@gmail.com> <945093c7-de5e-0350-6030-e4e79ea41161@gmail.com> <5aff247f-dfcb-cecf-e07e-b5fca877f911@gmail.com> <24e1d1ea-33a0-bab8-3182-1dbb90ff7e3c@gmail.com> From: Martin Sebor Message-ID: Date: Fri, 11 Jun 2021 08:46:10 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2021 14:46:13 -0000 On 6/11/21 3:58 AM, Richard Sandiford wrote: > Martin Sebor via Gcc-patches writes: >> diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c >> index 7b37e1b602c..7cdc824730c 100644 >> --- a/gcc/config/arm/arm.c >> +++ b/gcc/config/arm/arm.c >> @@ -13242,13 +13242,8 @@ bounds_check (rtx operand, HOST_WIDE_INT low, HOST_WIDE_INT high, >> lane = INTVAL (operand); >> >> if (lane < low || lane >= high) >> - { >> - if (exp) >> - error ("%K%s %wd out of range %wd - %wd", >> - exp, desc, lane, low, high - 1); >> - else >> - error ("%s %wd out of range %wd - %wd", desc, lane, low, high - 1); >> - } >> + error_at (EXPR_LOCATION (exp), >> + "%s %wd out of range %wd - %wd", desc, lane, low, high - 1); >> } >> >> /* Bounds-check lanes. */ > > This part doesn't look safe: “exp” is null when called from arm_const_bounds. Doh! Yes, will fix, thanks. Martin > > Thanks, > Richard >