From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id CD68B3858D39 for ; Tue, 27 Sep 2022 03:44:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD68B3858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.20.4.52] (unknown [10.20.4.52]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Dx_2uYcTJjgJQiAA--.61713S2; Tue, 27 Sep 2022 11:44:24 +0800 (CST) Subject: Re: [PATCH] Libvtv-test: Fix the problem that scansarif.exp cannot be found in libvtv regression test. To: WANG Xuerui , gcc-patches@gcc.gnu.org, mliska@suse.cz, dmalcolm@redhat.com Cc: xry111@xry111.site, xuchenghua@loongson.cn References: <20220927031639.186950-1-chenglulu@loongson.cn> <7861c25d-3397-43d9-f29a-7a3252dd5d49@xen0n.name> From: Lulu Cheng Message-ID: Date: Tue, 27 Sep 2022 11:44:24 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <7861c25d-3397-43d9-f29a-7a3252dd5d49@xen0n.name> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8Dx_2uYcTJjgJQiAA--.61713S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Kw47XrykAF47Xw4rCFWUCFg_yoW8uF4DpF 9Yka4vkrWxAFn7tw1kCFy09a4xKr4Fya43Gry5KF4xKrW7K34SvrWIvFZ09rnxZrs7Zryf Xr15X3Z3Zw15t3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvS14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26F1j6w1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4U JVWxJr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I8E87Iv6xkF7I0E14v26r xl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj 6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr 0_Gr1lF7xvr2IY64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7Mxk0xIA0c2IEe2xFo4CE bIxvr21lc2xSY4AK6svPMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI 8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AK xVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI 8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280 aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43 ZEXa7VUbrMaUUUUUU== X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,BODY_8BITS,GIT_PATCH_0,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Sorry, I will try to avoid this problem in the future. 在 2022/9/27 上午11:30, WANG Xuerui 写道: > > On 2022/9/27 11:16, Lulu Cheng wrote: >>     r13-967 add ARRIF output format. However libvtv does not add >> support. > > "SARIF support was added in r13-967 but libvtv wasn't updated." > > (Tip: always remember that English, unlike Chinese, isn't a > "topic-prominent" language, meaning you should almost never put the > "topic" at subject position of the sentence. IOW, if you find your > English to be a perfect 1:1 mapping to some Chinese sentence, which is > the case here, it's highly likely you need to improve it somehow. This > is by no means personal, but the same pattern of broken English has > been appearing in your and your teammates' commits since forever, so > I'm afraid I have to point out.) > >> >>     commit 6cf276ddf22066af780335cd0072d2c27aabe468 >>     Author: David Malcolm >>     Date:   Thu Jun 2 15:40:22 2022 -0400 >> >>         diagnostics: add SARIF output format > > And I don't think this reference is necessary, r13-967 is already a > precise description. > >> >> libvtv/ChangeLog: >> >>     * testsuite/lib/libvtv-dg.exp: Add load_gcc_lib of scansarif.exp. > "Load scansarif.exp." -- another example of redundant expression (no > pun intended on "expression"). >> --- >>   libvtv/testsuite/lib/libvtv-dg.exp | 2 ++ >>   1 file changed, 2 insertions(+) >> >> diff --git a/libvtv/testsuite/lib/libvtv-dg.exp >> b/libvtv/testsuite/lib/libvtv-dg.exp >> index b140c194cdc..454d916e556 100644 >> --- a/libvtv/testsuite/lib/libvtv-dg.exp >> +++ b/libvtv/testsuite/lib/libvtv-dg.exp >> @@ -12,6 +12,8 @@ >>   # along with this program; if not, write to the Free Software >>   # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA >> 02110-1301, USA. >>   +load_gcc_lib scansarif.exp >> + >>   proc libvtv-dg-test { prog do_what extra_tool_flags } { >>       return [gcc-dg-test-1 libvtv_target_compile $prog $do_what >> $extra_tool_flags] >>   } > Otherwise LGTM.