From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by sourceware.org (Postfix) with ESMTPS id 1574E3858D39 for ; Sun, 22 Oct 2023 19:45:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1574E3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1574E3858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::102c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698003919; cv=none; b=r+TcruxyKMtgqVb96G8AK0ORTeSJk7NCxmpKBdmvvFC3VX/cMP3UCesIfetMac8uE5GIAONI2+8wSasDm01cRnQtTHp7iLtQP/zN1SW5dZgCmhzHn5DpMGu7ZxpANG6rMmdxyoTWrOq3xH52htncQL7ZTTql3bCQZ4IqY7PGZy4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698003919; c=relaxed/simple; bh=Wg75OfRfkSWxEDeCOFK7CvtgNHWT44hz5jJzkuz763c=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=AZI3oIsC/Le7dbhVVP9dBJrp243W2KNtX3Vt4AgVg/C8Zyjz5axBGrkJQQbssfJpbua2g+cmgwSX06mzONojnhz4q60VPqT38BSDTgUEknTfVtsfZVlq7l2ij/XYDlPEJfvKAPSFrIIuTz5OZri8ujBl7b5KHCN66LdaVpC0vYE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-27cefb5ae1fso1546731a91.3 for ; Sun, 22 Oct 2023 12:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698003917; x=1698608717; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KMOdLmBgvC38jv3ZfXfPBygffNZLgZg/9zcKWBmBVQs=; b=DNFY12SfOjs2DtefhlfRz5NaVF+zHKZ13lPIEFgLGwMSW8HLtYPMCI9K+BoAIsuvq8 rHZ1MUYHyuP5IShmuPAFcMNfnJUYcOr3daRxAFQx18MNjyz/47GlZZOkeCGbp0J5agZS iMX8HhQu7PqWLuw7cOPXuDIdm5tHCcUh+MleupLjQi2QjGCmc6QPzu3OjklVpiXgjKvd gPmFEUPQySrXma7PWUvRb+DqTDbCtzt5EJGX3idE9cAoR8wpEUHq4PJangu6qV3q64RC q+tRLqhr+RPu9ao/0nOj2V08Mhgs4v+7FxF8NKDxoLtKhpdWsAHorKI6PWD0ofUOS7aK nNhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698003917; x=1698608717; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KMOdLmBgvC38jv3ZfXfPBygffNZLgZg/9zcKWBmBVQs=; b=jwg185L+mcoxYjelxnVOUS9wjCNVYmGTkLs5kN5aAsZzLONpYOWiG0Z1mZEF04qLVk yNaqk84YoGQsdQ43cA3NS/l4BriBFlOSLxcqNQAzEvSQVs4v2DYGDXXLpmVp2/E84sWJ YPpv2vpGvc7UpY9ixG14iI2A723iqU/6y8NyLhY72/oTi5yL5KCUCzlZO7yeo7+F4UAv 6JBUzBnbLIkoXjnGMwq5pvDWwK4/k/1KvDpyclKs2i2exIRkwpVNe8QZwtgnVSF+zf2S 9O4v33/jHBfnqMH9xB9OTfg58dEMhuE0PXl3tb7+vvCEgRM4zscyp/alEkNhh2yaOqc6 LnAw== X-Gm-Message-State: AOJu0Yx6CVe+GJoIErBt1k3zmuTTFvxSPpzxcNPKdR/+k7A8GKiqjYiY 4Fp93VU0RWJX3yagFIwaZqY= X-Google-Smtp-Source: AGHT+IHxWPk8hRJsv8d0WfqXHpQ8BEn1O/1BDSiHaW3xxVhBDXiuP1H8rJECLE9VYkRrJvwQizsWRg== X-Received: by 2002:a17:90a:1947:b0:27c:f80a:2c8a with SMTP id 7-20020a17090a194700b0027cf80a2c8amr5651748pjh.0.1698003916813; Sun, 22 Oct 2023 12:45:16 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id lw7-20020a17090b180700b0027df62a9e68sm4495468pjb.13.2023.10.22.12.45.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Oct 2023 12:45:16 -0700 (PDT) Message-ID: Date: Sun, 22 Oct 2023 13:45:12 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gcc.c-torture/execute/builtins/fputs.c: Define _GNU_SOURCE Content-Language: en-US To: Andrew Pinski , Florian Weimer Cc: gcc-patches@gcc.gnu.org References: <87zg0bhzep.fsf@oldenburg.str.redhat.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/22/23 10:09, Andrew Pinski wrote: > On Sun, Oct 22, 2023 at 12:47 AM Florian Weimer wrote: >> >> Current glibc headers only declare fputs_unlocked for _GNU_SOURCE. >> Defining the macro avoids an implicit function declaration. > > This does not help targets that don't use glibc though. > Note for builtins testsuite there is a lib-fputs.c file which will > define a fputs_unlock which is how it will link even if the libc does > not define a fputs_unlock. But isn't fputs_unlocked glibc specific to begin with? ie, the test really doesn't make sense AFAICT on non-glibc targets. Jeff