From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 689633858C2D for ; Fri, 2 Sep 2022 03:43:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 689633858C2D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2823V4XP022443; Fri, 2 Sep 2022 03:43:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=DMDm5FBJg28fqLwtvSoPI91At9cdW5oHR+V4EnNMgzA=; b=XL0FNF68CkPOIXrz4FjytFX9LL/E0xVLBUWdgvh9dNBpMyDgRnr9nwZn/Z51A3HBJaAl nu20ziG5Dlla5tUatlCIB++Jt4C5GBlGeSztjNCnsLZzIv+/Xfs5i0kyjJZAkn9rHMqG 7/vxjpy+JIDsMczxEIAdpAQ7l9HgU8TRnu74Ghiytc19zfxXMoY3ZR+k6RFkkkSrXsxI ZX16JXJPySi3b4pi6a0cjp/lExaJ6l6A2pScFLByHpGc2ljJv6+kxI+hFw8Y1MJxqLhn I5PV++gi7H28sCtE8Lh3PXTKdLeAEF72h7Ow5jMhZrabd+yzG14v3ZmlLilQ/tH5yNwG Gw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3jba0bge4q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 02 Sep 2022 03:43:37 +0000 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2823Wl3h028997; Fri, 2 Sep 2022 03:43:37 GMT Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3jba0bge4b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 02 Sep 2022 03:43:37 +0000 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2823avf8008690; Fri, 2 Sep 2022 03:43:35 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma03fra.de.ibm.com with ESMTP id 3j7aw8wh24-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 02 Sep 2022 03:43:35 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2823eDXx33292656 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 2 Sep 2022 03:40:13 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1A3A452050; Fri, 2 Sep 2022 03:43:32 +0000 (GMT) Received: from [9.200.43.154] (unknown [9.200.43.154]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 15E985204E; Fri, 2 Sep 2022 03:43:29 +0000 (GMT) Message-ID: Date: Fri, 2 Sep 2022 11:43:28 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2, rs6000] Put dg-options before effective target checks Content-Language: en-US To: Segher Boessenkool Cc: gcc-patches , David , "Kewen.Lin" , Peter Bergner References: <20055172-6ec9-6055-c02a-9f91b26e0296@linux.ibm.com> <20220901160758.GF25951@gate.crashing.org> From: HAO CHEN GUI In-Reply-To: <20220901160758.GF25951@gate.crashing.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: C1i_bWXAsaYTLCgNX0lnggx5e8WLbd-4 X-Proofpoint-ORIG-GUID: xeXVz7ANatJKVySA-CAciz-MxKFZtNuH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-09-01_12,2022-08-31_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 adultscore=0 impostorscore=0 malwarescore=0 mlxscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 spamscore=0 mlxlogscore=771 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2209020016 X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Segher, Thanks for your review comments. I will refine it according to your comments. On 2/9/2022 上午 12:07, Segher Boessenkool wrote: >> +/* { dg-do compile { target { ! has_arch_pwr9 } } } */ > Please keep dg-do first thing in the file. Could you inform me if it's a must to put dg-do in the first line? Here I hit a problem. "! has_arch_pwr9" can not be put into dg-require-effective-target as it has a NOT. So I put dg-options in the first line and make it ahead of dg-do. > >> --- a/gcc/testsuite/gcc.target/powerpc/pr93453-1.c >> +++ b/gcc/testsuite/gcc.target/powerpc/pr93453-1.c >> @@ -1,5 +1,6 @@ >> -/* { dg-do compile { target has_arch_ppc64 } } */ >> +/* { dg-do compile } */ >> /* { dg-options "-mdejagnu-cpu=power6 -O2" } */ >> +/* { dg-require-effective-target has_arch_ppc64 } */ > This is fine, but it doesn't change anything, unless we have a bug. This case suffer from "empty translation unit" problem and to be unsupported on all platform. Put dg-options before the check avoid the problem. Thanks Gui Haochen