From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id 0372E384AB67 for ; Mon, 22 Apr 2024 19:55:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0372E384AB67 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0372E384AB67 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::631 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713815723; cv=none; b=Kxu6UL2hwOAcQkKBr3dM5J01W89BxtcAmUzGmsizTevcyvnj9vr0x0A5w8SB45mfrktNAxHJ8ZdJCDKOWc2Ao6ecx+1NJk3ffibLPG4sKThXp50XlCKFNUFW4gA3djqWufV3Naez2qvyAdbGBXgk22Qum/7J/IkbPKnhfKThH+c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713815723; c=relaxed/simple; bh=PGOc6gsFxM0EEs1dfQIRJrnBA/lE3YeodDE0C8F+10Y=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=tw599BIP0rhLIInrU6WpMBFMctyUdhgtrxuWeRObpaOQAwZ+D8iYjVc+32oxZsiiEt2FY4V4eMGb2HnEfii4XUIq/VQh/zHfxT1J48MYfyQnPNTUboZkqvx7jLaKJxxbwX0lJzK7g20q/K4MyV+5YnIBAL5Q4TNvP17XNTn/T7c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1e3c9300c65so41496195ad.0 for ; Mon, 22 Apr 2024 12:55:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1713815720; x=1714420520; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6dOtC6APj8CV/8tBXKKZ4ftFK0Ko2nf29ET2dTa5NjM=; b=3abkgIqnm9mWAVHc3QIuOrPYmYZqpfJXee2yGuVdva0IoM4EpJ4xvuK+e6lofD3qSo 6dK3ghJ28kX5ScQsOScoduinac/8x/+Dzp1ttyQDm6Vwn0gwreJMaV88nm/NuXaiczwH SoRoHn/K7W68yutmBY2Zh5ZnUUMVJZmN3ThR2+yKgxx3gCIawWCeCtyzAibGILNVKJZS N508VrorVlQQPSkkSaJORGGwRGPE4mh9f3lgHftWuX80HIyBM0SNNPp+jC70Wy4Tf1Ga eCYkR3eb7Id91qsA4+is9PdiuVMXmB112bBDBtiZRj4vVbNHpwh0QaXBox15+4aWBqtz y3OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713815720; x=1714420520; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6dOtC6APj8CV/8tBXKKZ4ftFK0Ko2nf29ET2dTa5NjM=; b=WNNy5VTAyX3IGEafrRNK2dclq1/7nQ9gZvWmM6njAb3e7rfIV7/9gedQ6xzCuTE+qN yzwq/GyipxxfOvPNcRq7i3nJuQhF+ZK0F7wvXf32KvyINRQLI1iQ0J1LCfI+IyyMhGgL T7DAZZ7JIqCXhEUKLaCkpqUU9XtIpX+M8bu0N0h9VPnrD0lrsHaxlOG460tb2KG+Bxls e1C8l44Jx+WITwTI5QDIyHlg8KBfTTulfXpKN4f35FLVovobv4kiPD3f3TNS96QhJavM kAEgNvIcsTClDbglF244iubKL/mpw1Rvl6V+ZvG00qZsbLIWd10g9B/Jstcti23JRaLX 3p4w== X-Forwarded-Encrypted: i=1; AJvYcCUk5H256ndaJFIqGJYKUDXyPP8htO/yc9vLbVxtVT11L/1PPkC2YL1gKERhNKdShjxyZbAFkRBnvZovkmS8BpcIdK4YE8jtJA== X-Gm-Message-State: AOJu0YxfTPQJtOYR25bsveZQGuFNrbZc3eAFwIBJ4hSHT/0iV7hm8CY7 czZejBFNAYoC2qAW8Tz9fNQ29FYIx1IrYWMu6tRgHTAHorX44ScFKv7Q8Tz65Q4= X-Google-Smtp-Source: AGHT+IFOzSyfhgXMK2PiKZu8UzbddP9uVgfXIogIjiBsBSAunJ3zDVec8bkgpD8gVxhb/nXDz9WNyQ== X-Received: by 2002:a17:902:e889:b0:1e8:d85a:970 with SMTP id w9-20020a170902e88900b001e8d85a0970mr12013381plg.10.1713815719942; Mon, 22 Apr 2024 12:55:19 -0700 (PDT) Received: from [10.0.17.156] ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id o11-20020a1709026b0b00b001e289130862sm8509654plk.308.2024.04.22.12.55.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Apr 2024 12:55:19 -0700 (PDT) Message-ID: Date: Mon, 22 Apr 2024 12:55:17 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d and e65aaf8efe1 To: pan2.li@intel.com, gcc-patches@gcc.gnu.org Cc: juzhe.zhong@rivai.ai, kito.cheng@gmail.com, rdapp.gcc@gmail.com References: <20240422134734.1909499-1-pan2.li@intel.com> Content-Language: en-US From: Patrick O'Neill In-Reply-To: <20240422134734.1909499-1-pan2.li@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Pan, I was running the testsuite for this and noticed an ICE scroll by when this patch is applied to cacc55a4c0be8d0bc7417b6a28924eadbbe428e3 for rv64gcv: FAIL: gfortran.dg/graphite/pr29832.f90   -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions  (internal compiler error: in extract_insn, at recog.cc:2812) I'll send the full list of new failures once the runs finish. Thanks, Patrick On 4/22/24 06:47, pan2.li@intel.com wrote: > From: Pan Li > > After we reverted below 2 commits, the reference to attr need some > adjustment as the group_overlap is no longer available. > > * RISC-V: Robostify the W43, W86, W87 constraint enabled attribute > * RISC-V: Rename vconstraint into group_overlap > > The below tests are passed for this patch. > > * The rv64gcv fully regression tests. > > gcc/ChangeLog: > > * config/riscv/vector-crypto.md: > > Signed-off-by: Pan Li > --- > gcc/config/riscv/vector-crypto.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/riscv/vector-crypto.md b/gcc/config/riscv/vector-crypto.md > index 519c6a10d94..23dc549e5b8 100755 > --- a/gcc/config/riscv/vector-crypto.md > +++ b/gcc/config/riscv/vector-crypto.md > @@ -322,7 +322,7 @@ (define_insn "@pred_vwsll_scalar" > "vwsll.v%o4\t%0,%3,%4%p1" > [(set_attr "type" "vwsll") > (set_attr "mode" "") > - (set_attr "group_overlap" "W21,W21,W21,W21,W42,W42,W42,W42,W84,W84,W84,W84,none,none")]) > + (set_attr "vconstraint" "W21,W21,W21,W21,W42,W42,W42,W42,W84,W84,W84,W84,no,no")]) > > ;; vbrev.v vbrev8.v vrev8.v > (define_insn "@pred_v"