From: Sandra Loosemore <sandra@codesourcery.com>
To: Tobias Burnus <tobias@codesourcery.com>,
Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
Richard Biener <rguenther@suse.de>,
Thomas Schwinge <thomas@codesourcery.com>
Subject: Re: [Patch] Add 'default' to -foffload=; document that flag [PR67300]
Date: Thu, 17 Jun 2021 11:41:39 -0600 [thread overview]
Message-ID: <f598cbbe-8691-98cd-4937-8c31544209c9@codesourcery.com> (raw)
In-Reply-To: <e319c57b-dd25-e49b-066f-dfb642ea3d9e@codesourcery.com>
On 6/17/21 10:03 AM, Tobias Burnus wrote:
> Updated version – only lightly tested. I think it is
> consistent like that and the documentation should now be
> comprehensive. (I will have to do some additional testing.)
>
> Further comments and thoughts?
Hmmm, I had started to put together some comments on
grammar/punctuation/markup on the first version before the second
iteration showed up in my mailbox, but more critically I could not
figure out whether -foffload=default is supposed to be exactly identical
to the default behavior; if it isn't, it should be, or -foffload=default
ought to be renamed. So let's get that sorted out first. I suggest
reorganizing the documentation to first have a paragraph discussing the
default behavior, and then move on to how to modify it, with separate
paragraphs for enabling offload targets explicitly and on adding options
for offload compilation on all/some targets.
I think it would useful to add an example with a target list and
multiple options since I think the syntax looks pretty hairy.
-Sandra
next prev parent reply other threads:[~2021-06-17 17:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 12:08 Tobias Burnus
2021-06-17 12:27 ` Jakub Jelinek
2021-06-17 16:03 ` Tobias Burnus
2021-06-17 17:41 ` Sandra Loosemore [this message]
2021-06-17 17:50 ` Jakub Jelinek
2021-06-17 19:28 ` Tobias Burnus
2021-06-17 19:40 ` Jakub Jelinek
2021-06-17 21:57 ` Sandra Loosemore
2021-06-17 23:05 ` Tobias Burnus
2021-06-18 22:47 ` Sandra Loosemore
2021-06-28 11:28 ` Tobias Burnus
2021-06-28 15:51 ` Tobias Burnus
2021-06-28 22:34 ` Sandra Loosemore
2021-06-29 11:58 ` Jakub Jelinek
2021-06-29 13:47 ` Tobias Burnus
2021-06-29 13:51 ` Jakub Jelinek
2021-06-29 20:47 ` Rainer Orth
2021-06-29 21:02 ` Christophe Lyon
2021-06-30 20:12 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f598cbbe-8691-98cd-4937-8c31544209c9@codesourcery.com \
--to=sandra@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
--cc=thomas@codesourcery.com \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).