From: Lulu Cheng <chenglulu@loongson.cn>
To: David Malcolm <dmalcolm@redhat.com>,
gcc-patches@gcc.gnu.org, mliska@suse.cz
Cc: xry111@xry111.site, xuchenghua@loongson.cn, i@xen0n.name
Subject: Re: [PATCH v2] Libvtv-test: Fix bug that scansarif.exp cannot be found in libvtv regression test.
Date: Wed, 12 Oct 2022 10:53:15 +0800 [thread overview]
Message-ID: <f5a60fd3-7c1c-15ae-d97d-b142f0b55327@loongson.cn> (raw)
In-Reply-To: <be136d412a338e167567ed6b7072d7e9d623b581.camel@redhat.com>
Pushed to r13-3241
在 2022/9/27 下午10:01, David Malcolm 写道:
> On Tue, 2022-09-27 at 14:02 +0800, Lulu Cheng wrote:
>> SARIF support was added in r13-967 but libvtv wasn't updated.
> Sorry about breaking this. The patch looks reasonable to me, FWIW,
> assuming that it fixes the issue, of course!
>
> Looks like my normal testing process missed this when I was testing the
> SARIF patch; presumably we need to configure with --enable-vtable-
> verify=yes to enable this feature.
>
> Thanks
> Dave
>
>> libvtv/ChangeLog:
>>
>> * testsuite/lib/libvtv-dg.exp: Add load_gcc_lib of
>> scansarif.exp.
>> ---
>> libvtv/testsuite/lib/libvtv-dg.exp | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/libvtv/testsuite/lib/libvtv-dg.exp
>> b/libvtv/testsuite/lib/libvtv-dg.exp
>> index b140c194cdc..454d916e556 100644
>> --- a/libvtv/testsuite/lib/libvtv-dg.exp
>> +++ b/libvtv/testsuite/lib/libvtv-dg.exp
>> @@ -12,6 +12,8 @@
>> # along with this program; if not, write to the Free Software
>> # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
>> 02110-1301, USA.
>>
>> +load_gcc_lib scansarif.exp
>> +
>> proc libvtv-dg-test { prog do_what extra_tool_flags } {
>> return [gcc-dg-test-1 libvtv_target_compile $prog $do_what
>> $extra_tool_flags]
>> }
prev parent reply other threads:[~2022-10-12 2:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 6:02 Lulu Cheng
2022-09-27 14:01 ` David Malcolm
2022-09-28 3:05 ` Lulu Cheng
2022-10-12 2:53 ` Lulu Cheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5a60fd3-7c1c-15ae-d97d-b142f0b55327@loongson.cn \
--to=chenglulu@loongson.cn \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=i@xen0n.name \
--cc=mliska@suse.cz \
--cc=xry111@xry111.site \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).