From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 5E9A63856DC3 for ; Wed, 12 Oct 2022 02:53:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5E9A63856DC3 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.20.4.52] (unknown [10.20.4.52]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxbWsbLEZjt4IrAA--.44384S2; Wed, 12 Oct 2022 10:53:15 +0800 (CST) Subject: Re: [PATCH v2] Libvtv-test: Fix bug that scansarif.exp cannot be found in libvtv regression test. To: David Malcolm , gcc-patches@gcc.gnu.org, mliska@suse.cz Cc: xry111@xry111.site, xuchenghua@loongson.cn, i@xen0n.name References: <20220927060228.573975-1-chenglulu@loongson.cn> From: Lulu Cheng Message-ID: Date: Wed, 12 Oct 2022 10:53:15 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8CxbWsbLEZjt4IrAA--.44384S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Cw1rtw17Ww47tF1DWFy3Jwb_yoW8GrWDpF yktasYkFy7Xr1kGwnrJry0k3y7Kr4rtay7Cr1rKF40grW7Ga4SvryIvrZI9FnxXws3ZF1f Jr48Z3WDZw1jq3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvq14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26F 4UJVW0owAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv 7VC0I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r 1j6r4UM4x0Y48IcVAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCYjI0SjxkI62AI1cAE 67vIY487MxkIecxEwVCm-wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8Jw C20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAF wI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjx v20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2 jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0x ZFpf9x0JUdEfOUUUUU= X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,BODY_8BITS,GIT_PATCH_0,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Pushed to r13-3241 在 2022/9/27 下午10:01, David Malcolm 写道: > On Tue, 2022-09-27 at 14:02 +0800, Lulu Cheng wrote: >>         SARIF support was added in r13-967 but libvtv wasn't updated. > Sorry about breaking this. The patch looks reasonable to me, FWIW, > assuming that it fixes the issue, of course! > > Looks like my normal testing process missed this when I was testing the > SARIF patch; presumably we need to configure with --enable-vtable- > verify=yes to enable this feature. > > Thanks > Dave > >> libvtv/ChangeLog: >> >>         * testsuite/lib/libvtv-dg.exp: Add load_gcc_lib of >> scansarif.exp. >> --- >>  libvtv/testsuite/lib/libvtv-dg.exp | 2 ++ >>  1 file changed, 2 insertions(+) >> >> diff --git a/libvtv/testsuite/lib/libvtv-dg.exp >> b/libvtv/testsuite/lib/libvtv-dg.exp >> index b140c194cdc..454d916e556 100644 >> --- a/libvtv/testsuite/lib/libvtv-dg.exp >> +++ b/libvtv/testsuite/lib/libvtv-dg.exp >> @@ -12,6 +12,8 @@ >>  # along with this program; if not, write to the Free Software >>  # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA >> 02110-1301, USA. >> >> +load_gcc_lib scansarif.exp >> + >>  proc libvtv-dg-test { prog do_what extra_tool_flags } { >>      return [gcc-dg-test-1 libvtv_target_compile $prog $do_what >> $extra_tool_flags] >>  }