* [PATCH v2] Libvtv-test: Fix bug that scansarif.exp cannot be found in libvtv regression test.
@ 2022-09-27 6:02 Lulu Cheng
2022-09-27 14:01 ` David Malcolm
0 siblings, 1 reply; 4+ messages in thread
From: Lulu Cheng @ 2022-09-27 6:02 UTC (permalink / raw)
To: gcc-patches, mliska, dmalcolm; +Cc: xry111, xuchenghua, i, Lulu Cheng
SARIF support was added in r13-967 but libvtv wasn't updated.
libvtv/ChangeLog:
* testsuite/lib/libvtv-dg.exp: Add load_gcc_lib of scansarif.exp.
---
libvtv/testsuite/lib/libvtv-dg.exp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libvtv/testsuite/lib/libvtv-dg.exp b/libvtv/testsuite/lib/libvtv-dg.exp
index b140c194cdc..454d916e556 100644
--- a/libvtv/testsuite/lib/libvtv-dg.exp
+++ b/libvtv/testsuite/lib/libvtv-dg.exp
@@ -12,6 +12,8 @@
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+load_gcc_lib scansarif.exp
+
proc libvtv-dg-test { prog do_what extra_tool_flags } {
return [gcc-dg-test-1 libvtv_target_compile $prog $do_what $extra_tool_flags]
}
--
2.31.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] Libvtv-test: Fix bug that scansarif.exp cannot be found in libvtv regression test.
2022-09-27 6:02 [PATCH v2] Libvtv-test: Fix bug that scansarif.exp cannot be found in libvtv regression test Lulu Cheng
@ 2022-09-27 14:01 ` David Malcolm
2022-09-28 3:05 ` Lulu Cheng
2022-10-12 2:53 ` Lulu Cheng
0 siblings, 2 replies; 4+ messages in thread
From: David Malcolm @ 2022-09-27 14:01 UTC (permalink / raw)
To: Lulu Cheng, gcc-patches, mliska; +Cc: xry111, xuchenghua, i
On Tue, 2022-09-27 at 14:02 +0800, Lulu Cheng wrote:
> SARIF support was added in r13-967 but libvtv wasn't updated.
Sorry about breaking this. The patch looks reasonable to me, FWIW,
assuming that it fixes the issue, of course!
Looks like my normal testing process missed this when I was testing the
SARIF patch; presumably we need to configure with --enable-vtable-
verify=yes to enable this feature.
Thanks
Dave
>
> libvtv/ChangeLog:
>
> * testsuite/lib/libvtv-dg.exp: Add load_gcc_lib of
> scansarif.exp.
> ---
> libvtv/testsuite/lib/libvtv-dg.exp | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libvtv/testsuite/lib/libvtv-dg.exp
> b/libvtv/testsuite/lib/libvtv-dg.exp
> index b140c194cdc..454d916e556 100644
> --- a/libvtv/testsuite/lib/libvtv-dg.exp
> +++ b/libvtv/testsuite/lib/libvtv-dg.exp
> @@ -12,6 +12,8 @@
> # along with this program; if not, write to the Free Software
> # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
> 02110-1301, USA.
>
> +load_gcc_lib scansarif.exp
> +
> proc libvtv-dg-test { prog do_what extra_tool_flags } {
> return [gcc-dg-test-1 libvtv_target_compile $prog $do_what
> $extra_tool_flags]
> }
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] Libvtv-test: Fix bug that scansarif.exp cannot be found in libvtv regression test.
2022-09-27 14:01 ` David Malcolm
@ 2022-09-28 3:05 ` Lulu Cheng
2022-10-12 2:53 ` Lulu Cheng
1 sibling, 0 replies; 4+ messages in thread
From: Lulu Cheng @ 2022-09-28 3:05 UTC (permalink / raw)
To: David Malcolm, gcc-patches, mliska; +Cc: xry111, xuchenghua, i
在 2022/9/27 下午10:01, David Malcolm 写道:
> On Tue, 2022-09-27 at 14:02 +0800, Lulu Cheng wrote:
>> SARIF support was added in r13-967 but libvtv wasn't updated.
> Sorry about breaking this. The patch looks reasonable to me, FWIW,
> assuming that it fixes the issue, of course!
>
> Looks like my normal testing process missed this when I was testing the
> SARIF patch; presumably we need to configure with --enable-vtable-
> verify=yes to enable this feature.
>
> Thanks
> Dave
>
Hi, Dave:
I have passed the test, if there is no problem, I will merge into the
master branch.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] Libvtv-test: Fix bug that scansarif.exp cannot be found in libvtv regression test.
2022-09-27 14:01 ` David Malcolm
2022-09-28 3:05 ` Lulu Cheng
@ 2022-10-12 2:53 ` Lulu Cheng
1 sibling, 0 replies; 4+ messages in thread
From: Lulu Cheng @ 2022-10-12 2:53 UTC (permalink / raw)
To: David Malcolm, gcc-patches, mliska; +Cc: xry111, xuchenghua, i
Pushed to r13-3241
在 2022/9/27 下午10:01, David Malcolm 写道:
> On Tue, 2022-09-27 at 14:02 +0800, Lulu Cheng wrote:
>> SARIF support was added in r13-967 but libvtv wasn't updated.
> Sorry about breaking this. The patch looks reasonable to me, FWIW,
> assuming that it fixes the issue, of course!
>
> Looks like my normal testing process missed this when I was testing the
> SARIF patch; presumably we need to configure with --enable-vtable-
> verify=yes to enable this feature.
>
> Thanks
> Dave
>
>> libvtv/ChangeLog:
>>
>> * testsuite/lib/libvtv-dg.exp: Add load_gcc_lib of
>> scansarif.exp.
>> ---
>> libvtv/testsuite/lib/libvtv-dg.exp | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/libvtv/testsuite/lib/libvtv-dg.exp
>> b/libvtv/testsuite/lib/libvtv-dg.exp
>> index b140c194cdc..454d916e556 100644
>> --- a/libvtv/testsuite/lib/libvtv-dg.exp
>> +++ b/libvtv/testsuite/lib/libvtv-dg.exp
>> @@ -12,6 +12,8 @@
>> # along with this program; if not, write to the Free Software
>> # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
>> 02110-1301, USA.
>>
>> +load_gcc_lib scansarif.exp
>> +
>> proc libvtv-dg-test { prog do_what extra_tool_flags } {
>> return [gcc-dg-test-1 libvtv_target_compile $prog $do_what
>> $extra_tool_flags]
>> }
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-12 2:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-27 6:02 [PATCH v2] Libvtv-test: Fix bug that scansarif.exp cannot be found in libvtv regression test Lulu Cheng
2022-09-27 14:01 ` David Malcolm
2022-09-28 3:05 ` Lulu Cheng
2022-10-12 2:53 ` Lulu Cheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).