From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2082 invoked by alias); 25 Sep 2018 13:34:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 2068 invoked by uid 89); 25 Sep 2018 13:34:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=morning X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Sep 2018 13:34:23 +0000 Received: from smtp.corp.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9B6FB308FB86; Tue, 25 Sep 2018 13:34:22 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-5.rdu2.redhat.com [10.10.112.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 825DED6BFC; Tue, 25 Sep 2018 13:34:21 +0000 (UTC) Subject: Re: [PATCH 2/4] Remove unused functions and fields. To: Richard Biener , =?UTF-8?Q?Martin_Li=c5=a1ka?= Cc: GCC Patches References: <192f112275eb2c7bc74fdd3b91c0b32882695d22.1537774329.git.mliska@suse.cz> <43d7b949-b909-6c5a-866a-d7a8f56e26b2@redhat.com> <5386add0-0af1-d604-96e6-dab0e565924b@suse.cz> From: Jeff Law Openpgp: preference=signencrypt Message-ID: Date: Tue, 25 Sep 2018 13:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg01434.txt.bz2 On 9/25/18 6:19 AM, Richard Biener wrote: > On Tue, Sep 25, 2018 at 9:09 AM Martin Liška wrote: >> >> On 9/24/18 4:42 PM, Jeff Law wrote: >>> On 9/22/18 1:08 PM, marxin wrote: >>>> >>>> gcc/ChangeLog: >>>> >>>> 2018-09-24 Martin Liska >>>> >>>> * alias.c (set_dest_equal_p): Remove unused function. >>>> * config/i386/i386.c (def_builtin_pure2): Likewise. >>>> * diagnostic-show-locus.c (class layout): Remove >>>> unused field. >>>> (layout::layout): Likewise here. >>>> * dump-context.h (class temp_dump_context): Likewise. >>>> * dwarf2out.c (add_AT_fde_ref): Remove unused function. >>>> (add_AT_loclistsptr): Likewise. >>>> (add_AT_offset): Likewise. >>>> (get_AT_hi_pc): Likewise. >>>> (is_comdat_die): Likewise. >>>> (type_is_enum): Likewise. >>>> (ceiling): Likewise. >>>> (add_AT_vms_delta): Likewise. >>>> (is_class_die): Likewise. >>>> * edit-context.c (class line_event): Remove unused field. >>>> * graphite-sese-to-poly.c (tree_int_to_gmp): Remove >>>> unused function. >>>> * ipa-cp.c (ipa_get_vr_lat): Likewise. >>>> * lra-constraints.c (ok_for_index_p_nonstrict): Likewise. >>>> (ok_for_base_p_nonstrict): Likewise. >>>> * tree-chrec.c (is_not_constant_evolution): Likewise. >>>> (chrec_fold_poly_cst): Likewise. >>>> * tree-if-conv.c (has_pred_critical_p): Likewise. >>>> * tree-ssa-coalesce.c (print_exprs): Likewise. >>>> * tree-ssa-pre.c (bitmap_set_contains_expr): Likewise. >>>> * tree-ssa-uninit.c (is_and_or_or_p): Likewise. >>>> * tree-vrp.c (value_ranges_intersect_p): Likewise. >>>> (value_range_nonnegative_p): Likewise. >>>> >>>> gcc/cp/ChangeLog: >>>> >>>> 2018-09-24 Martin Liska >>>> >>>> * name-lookup.c (namespace_scope_ht_size): Remove >>>> unused function. >>>> * parser.c (cp_lexer_next_token_is_not_keyword): Likewise. >>>> >>>> gcc/fortran/ChangeLog: >>>> >>>> 2018-09-24 Martin Liska >>>> >>>> * trans.c (remove_suffix): Remove >>>> unused function. >>>> >>>> gcc/go/ChangeLog: >>>> >>>> 2018-09-24 Martin Liska >>>> >>>> * gofrontend/escape.cc (Gogo::analyze_escape): Remove >>>> usage of a parameter. >>>> (Gogo::assign_connectivity): Likewise. >>>> (class Escape_analysis_tag): Likewise. >>>> (Gogo::tag_function): Likewise. >>>> * gofrontend/expressions.cc (Call_expression::do_type): Likewise. >>>> * gofrontend/gogo.h (class Gogo): Likewise. >>>> * gofrontend/types.cc (class Call_multiple_result_type): Likewise. >>>> (Type::make_call_multiple_result_type): Likewise. >>>> * gofrontend/types.h (class Type): Likewise. >>>> * gofrontend/wb.cc (class Check_escape): Likewise. >>>> (Gogo::add_write_barriers): Likewise. >>> Note that some of these may be used inside conditional code. For >>> example the add_AT_vms_delta is used by ia64-vms. You could argue that >>> ia64-vms is a zombie and should be removed, but the general concern WRT >>> conditionally compiled code holds. >> >> Well, please let me install the patch as is and if somebody will need the >> functionality, I would be happy to put it back. > > You could use contrib/config-list.mk to build all supported target configs. You > shouldn't break builds for valid configs deliberately Right. On a suitably large box it only takes a few hours. Fire it off at the end of the day and you've got results in the morning. So how about this, if it passes config-list.mk then it's OK. Obviously it's OK to retain any functions that are flagged as necessary by config-list.mk. Alternately find + grep is your friend, but I find config-list.mk is better. jeff