From: "Martin Liška" <mliska@suse.cz>
To: Jonathan Wakely <jwakely.gcc@gmail.com>
Cc: Gerald Pfeifer <gerald@pfeifer.com>,
Jakub Jelinek <jakub@redhat.com>,
"gcc@gcc.gnu.org" <gcc@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [IMPORTANT] ChangeLog related changes
Date: Tue, 2 Jun 2020 16:06:10 +0200 [thread overview]
Message-ID: <f5f9b9d2-cf25-9892-2b49-837e5d1d3d9a@suse.cz> (raw)
In-Reply-To: <CAH6eHdSR+eo95x41=q0k6CQxMT-NF1KTwtdPY27ce2HJE5zaHQ@mail.gmail.com>
On 6/2/20 3:56 PM, Jonathan Wakely wrote:
> On Tue, 2 Jun 2020 at 14:16, Martin Liška <mliska@suse.cz> wrote:
>>
>> On 6/2/20 1:48 PM, Martin Liška wrote:
>>> I tend to this approach. Let me prepare a patch candidate for it.
>>
>> There's a patch for it. Can you please Jonathan take a look?
>
> Looks great, thanks!
>
> + if name not in wildcard_prefixes:
> + msg = 'unsupported wilcard prefix'
>
> Typo "wilcard"
>
> + if pattern not in used_patterns:
> + self.errors.append(Error('a file pattern not used in a patch',
> + pattern))
>
> If the script printed this error I don't think I'd know what it was
> complaining about. How about "pattern doesn't match any changed files"
> ?
Yes, thank you for the corrections. I've just pushed that to master.
Martin
>
> I find the existing error 'file not changed in a patch' to be
> suboptimal too. We're checking revisions (or commits), not patches.
>
next prev parent reply other threads:[~2020-06-02 14:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 22:48 Jakub Jelinek
2020-05-26 5:22 ` Hongtao Liu
2020-05-26 6:08 ` Martin Liška
2020-05-26 6:10 ` Hongtao Liu
2020-06-01 17:24 ` Jonathan Wakely
2020-06-02 6:44 ` Martin Liška
2020-06-02 11:06 ` Jonathan Wakely
2020-06-02 10:55 ` Gerald Pfeifer
2020-06-02 11:05 ` Jonathan Wakely
2020-06-02 11:09 ` Jonathan Wakely
2020-06-02 11:22 ` Jonathan Wakely
2020-06-02 11:48 ` Martin Liška
2020-06-02 13:16 ` Martin Liška
2020-06-02 13:56 ` Jonathan Wakely
2020-06-02 14:06 ` Martin Liška [this message]
2020-06-02 14:14 ` Jonathan Wakely
2020-06-02 14:25 ` Martin Liška
2020-06-09 20:29 ` Jonathan Wakely
2020-06-10 7:37 ` Martin Liška
2020-06-10 13:34 ` Tamar Christina
2020-06-10 13:39 ` Marek Polacek
2020-06-10 13:41 ` Martin Liška
2020-06-10 14:53 ` Tamar Christina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5f9b9d2-cf25-9892-2b49-837e5d1d3d9a@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=gerald@pfeifer.com \
--cc=jakub@redhat.com \
--cc=jwakely.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).