From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id B2CF73870849; Tue, 2 Jun 2020 14:06:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B2CF73870849 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mliska@suse.cz X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id F0763AC12; Tue, 2 Jun 2020 14:06:13 +0000 (UTC) Subject: Re: [IMPORTANT] ChangeLog related changes To: Jonathan Wakely Cc: Gerald Pfeifer , Jakub Jelinek , "gcc@gcc.gnu.org" , gcc-patches References: <20200525224858.GO8462@tucnak> <58fa71e3-cbc1-7bbd-47ef-fd4f226fc7a5@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: Date: Tue, 2 Jun 2020 16:06:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2020 14:06:16 -0000 On 6/2/20 3:56 PM, Jonathan Wakely wrote: > On Tue, 2 Jun 2020 at 14:16, Martin Liška wrote: >> >> On 6/2/20 1:48 PM, Martin Liška wrote: >>> I tend to this approach. Let me prepare a patch candidate for it. >> >> There's a patch for it. Can you please Jonathan take a look? > > Looks great, thanks! > > + if name not in wildcard_prefixes: > + msg = 'unsupported wilcard prefix' > > Typo "wilcard" > > + if pattern not in used_patterns: > + self.errors.append(Error('a file pattern not used in a patch', > + pattern)) > > If the script printed this error I don't think I'd know what it was > complaining about. How about "pattern doesn't match any changed files" > ? Yes, thank you for the corrections. I've just pushed that to master. Martin > > I find the existing error 'file not changed in a patch' to be > suboptimal too. We're checking revisions (or commits), not patches. >